Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace imported types #128

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Namespace imported types #128

merged 3 commits into from
Jul 18, 2022

Conversation

arendjr
Copy link
Contributor

@arendjr arendjr commented Jul 15, 2022

Places imported types in the TypeScript runtime's index.ts file in a namespace to avoid conflicts with other built-in browser types.

@arendjr arendjr requested a review from a team as a code owner July 15, 2022 13:36
sagacity
sagacity approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@sagacity sagacity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this needs to be listed in the changelog as well.

@arendjr arendjr merged commit 4bea242 into main Jul 18, 2022
@arendjr arendjr deleted the namespace-imported-types branch July 18, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagacity sagacity sagacity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arendjr @sagacity