Updating To latest version of sqlite3 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fhellwig @hellwfr Frank! Do you think this could be merged? |
|
Thanks a lot! 💚 |
|
NP - thanks for the PR. Also updated Mocha. All tests pass. Version 1.1.1 now published in NPM.
Best,
Frank
…----- Original message -----
From: "Joël Galeran" <notifications@github.com>
To: fhellwig/sqlite-async <sqlite-async@noreply.github.com>
Cc: Frank Hellwig <frank@hellwig.org>, State change <state_change@noreply.github.com>
Subject: Re: [fhellwig/sqlite-async] Updating To latest version of sqlite3 (#8)
Date: Wednesday, December 02, 2020 05:54
Thanks a lot! 💚
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM75KDFQB7LA43ROTOLPMDSSYMFZANCNFSM4TPXGIEQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes this issue TryGhost/node-sqlite3#1322 when installing sqlite3 it would always build the binary rather than downloading the cached/pre-built version from aws.