Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building for ARM-based macOS #119

Closed
wants to merge 1 commit into from
Closed

Fix building for ARM-based macOS #119

wants to merge 1 commit into from

Conversation

NeRdTheNed
Copy link

  • Fixed a typo in the arch flags
  • Changed the signature of the zlib ARM crc32 implementation to match the exported zlib signature

- Fixed a typo in the arch flags
- Changed the signature of the zlib ARM crc32 implementation to match the exported zlib signature
@fhanau fhanau closed this in 65bbf07 Jan 27, 2023
@fhanau
Copy link
Owner

fhanau commented Jan 27, 2023

Implemented the fix. Note that changing the function signature of the ARM crc32 in this case actually causes the checksum to be corrupted, perhaps because it changes the return value from 32 to 64 bits. Of course having mismatching function signatures should be avoided, but for now removing the header containing the function prototype for ARM fixes the compilation and does not result in invalid signatures.
I will develop a proper patch later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants