Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Visual Studio build #100

Merged
merged 1 commit into from
Aug 16, 2022
Merged

fix Visual Studio build #100

merged 1 commit into from
Aug 16, 2022

Conversation

krishty
Copy link

@krishty krishty commented Aug 15, 2022

  • do not pass Clang/GCC-specific settings to MSVC
  • set the relevant OptiPNG switches with MSVC
  • MSVC requires “__forceinline” in place of “attribute((always_inline))”

This addresses #99

fix Visual Studio build
ce1298c 
- do not pass Clang/GCC-specific settings to MSVC
- set the relevant OptiPNG switches with MSVC
- MSVC requires “__forceinline” in place of “__attribute__((always_inline))”
@krishty krishty mentioned this pull request Aug 15, 2022
Closed
@fhanau fhanau merged commit da53456 into fhanau:master Aug 16, 2022
@fhanau
Copy link
Owner

fhanau commented Aug 16, 2022

Thanks again! I'll try to be more careful about portability in the future.

@krishty krishty deleted the fix-vs-build branch August 16, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krishty @fhanau