Merge pull request #161 from boeddeker/master

fix git dependency in setup.py
fgnt · Jun 21, 2024 · bff1044 · bff1044
2 parents e968960 + 5cf7c1d
commit bff1044
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/maintenance.md b/maintenance.md
@@ -40,6 +40,7 @@ pip install --upgrade bump2version
 ## Publish
 
 ```bash
+export SETUP_PY_IGNORE_GIT_DEPENDENCIES=1
 bump2version --verbose --tag patch  # major, minor or patch
 python setup.py sdist  # bdist_wheel  # It is difficult to get bdist_wheel working with binary files
 git push origin --tags

diff --git a/setup.py b/setup.py
@@ -4,7 +4,7 @@
 https://packaging.python.org/en/latest/distributing.html
 https://github.com/pypa/sampleproject
 """
-
+import os
 # Allow editable install into user site directory.
 # See https://github.com/pypa/pip/issues/7953.
 import site
@@ -47,7 +47,7 @@
     'codecarbon',
 ]
 
-if sys.argv == ['setup.py', 'sdist']:
+if os.environ.get('SETUP_PY_IGNORE_GIT_DEPENDENCIES', False):
     # Remove git dependencies for sdist, because they are not supported on
     # pypi.
     # Can't have direct dependency: pb_bss@ git+http://github.com/fgnt/pb_bss ; extra == "test".