Test more node versions #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kherock
reviewed
Mar 26, 2022
lib/legacy-loader.mjs
Outdated
| throw err; | ||
| } catch (error) { | ||
| if (error.code !== 'ERR_UNKNOWN_FILE_EXTENSION') throw error; | ||
| return require('get-package-type')(filePath).then(format => ({ format, source: null })); |
There was a problem hiding this comment.
This shouldn't break anything, but getFormat's return value should only have the format key.
lib/index.js
Outdated
Comment on lines
101
to
116
|
|
||
| const legacyPrefix = semver.satisfies(process.version, '<16.12.0') ? 'legacy-' : ''; | ||
| const loaderURL = pathToFileURL(resolveMain(localPath(`${legacyPrefix}loader.mjs`))); | ||
| const experimentalPrefix = semver.satisfies(process.version, '>=12.11.1') | ||
| ? 'experimental-' | ||
| : ''; | ||
|
|
||
| args.push(`--${experimentalPrefix}loader=${loaderURL.href}`); | ||
|
|
There was a problem hiding this comment.
I think the code golf here might be overfitting to what the loader options currently are. I'm concerned that when the loader option's name inevitably changes again in the future that all of this string concatenation won't be a maintainable approach.
There was a problem hiding this comment.
Sorry, I just get annoyed when both sides of an if statement have the same function call with different arguments.
bjornstar
force-pushed
the
test-more-node-versions
branch
from
6f22025 to
9bfee6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure which version added the emitWarning method, but at least on node v12.16 it doesn't work.