experiment: separate out chroma deblock and start unrolling#285
Draft
stone-d-chen wants to merge 1 commit intoffvvc:deblock_asm_20250223from
Draft
experiment: separate out chroma deblock and start unrolling#285stone-d-chen wants to merge 1 commit intoffvvc:deblock_asm_20250223from
stone-d-chen wants to merge 1 commit intoffvvc:deblock_asm_20250223from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extremely rough draft for implementing AVX2 support.
Separated out the chroma and luma loop just for experimentation purposes.
Unroll loop
for (int x = x0 ? x0 : grid; x < x_end; x += 2 * grid)and compute two blocks per loop.I think I'll need to change the function signature to take a parameter specifying the number of blocks to process at a time.
OR if there's always an even number of blocks to process, just always assume there's two blocks available.