Skip to content

vvc_deblock.c: fix RANDCLIP #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stone-d-chen wants to merge 1 commit into
base: deblock_asm_20250223
Choose a base branch
from
Open

vvc_deblock.c: fix RANDCLIP #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/checkasm/vvc_deblock.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ static const uint32_t pixel_mask[3] = {0xffffffff, 0x03ff03ff, 0x0fff0fff};
else \
*(uint16_t*)(&x) = z; \
} while (0)
#define RANDCLIP(x, diff) av_clip(GET(x) - (diff), 0, \
(1 << (bit_depth)) - 1) + rnd() % FFMAX(2 * (diff), 1)
#define RANDCLIP(x, diff) av_clip(GET(x) - (diff) + rnd() % FFMAX(2 * (diff), 1), \
Copy link
Member

@nuomi2021 nuomi2021 Feb 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Stone,
Do we need to update HEVC as well?
If so, could you submit the HEVC patch for upstream review first?

Copy link
Collaborator Author

@stone-d-chen stone-d-chen Feb 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep sounds good!

0, (1 << (bit_depth)) - 1)

static void randomize_params(int32_t *beta, int32_t *tc, const int is_luma, const int bit_depth, const int size)
{
Expand Down
Loading