-
Notifications
You must be signed in to change notification settings - Fork 12
Fix some old comments #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
QSXW
wants to merge
6
commits into
ffvvc:up
Choose a base branch
from
QSXW:fix/comments
base: up
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fd5a4ec
avcodec/vvc_parser: move avctx->has_b_frames initialization to dec
QSXW f2efe39
avcodec/vvc/cabac: remove vvc_refill2
QSXW 09897bc
avcodec/vvc/dsp: prefix TxType and TxSize with VVC
QSXW 7aa51c2
add github workflow
nuomi2021 00e07d8
Add fuzz regression test
frankplow ea23de0
Fix fuzz test path
frankplow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| name: test | ||
| run-name: ${{ github.workflow }} - ${{ github.sha }} | ||
| on: | ||
| push: | ||
| branches: [ main, up ] | ||
| pull_request: | ||
| branches: [ main, up ] | ||
| workflow_dispatch: | ||
|
|
||
|
|
||
| jobs: | ||
| ffvvc-test: | ||
| name: ffvvc-test / ${{ matrix.os.name }}/${{ matrix.compiler.name }}/${{ matrix.assembler.name }} | ||
| env: | ||
| configure_flags: --enable-ffmpeg --disable-everything --enable-decoder=vvc --enable-parser=vvc --enable-demuxer=vvc --enable-protocol=file,pipe --enable-encoder=rawvideo,wrapped_avframe --enable-muxer=rawvideo,md5,null | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: | ||
| - { name: linux, runner: ubuntu-latest, shell: bash, runner_threads: 4 } | ||
| - { name: windows, runner: windows-latest, shell: 'msys2 {0}', runner_threads: 1 } | ||
| compiler: | ||
| - { name: gcc, flags: --cc=gcc } | ||
| - { name: clang, flags: --cc=clang } | ||
| - { name: msvc, flags: --toolchain=msvc } | ||
| - { name: clang-usan, flags: '--toolchain=clang-usan' } | ||
| - { name: clang-asan, flags: '--toolchain=clang-asan' } | ||
| assembler: | ||
| - { name: no asm, flags: --disable-asm } | ||
| - { name: yasm, flags: --as=yasm } | ||
| - { name: nasm, flags: --as=nasm } | ||
| exclude: | ||
| # GitHub's Actions runners do not support AVX2. | ||
| - os: { name: linux, runner: ubuntu-latest, shell: bash, runner_threads: 4} | ||
| compiler: { name: msvc, flags: --toolchain=msvc } | ||
| - os: { name: linux, runner: ubuntu-latest, shell: bash, runner_threads: 4 } | ||
| assembler: { name: yasm, flags: --as=yasm } | ||
| - os: { name: linux, runner: ubuntu-latest, shell: bash, runner_threads: 4 } | ||
| assembler: { name: nasm, flags: --as=nasm } | ||
| # Address sanitizer cannot be run with handwritten assembly. | ||
| - compiler: { name: clang-asan, flags: '--toolchain=clang-asan' } | ||
| assembler: { name: nasm, flags: --as=nasm } | ||
| - compiler: { name: clang-asan, flags: '--toolchain=clang-asan' } | ||
| assembler: { name: yasm, flags: --as=yasm } | ||
| # Windows only supports MSVC. | ||
| - os: { name: windows, runner: windows-latest, shell: 'msys2 {0}', runner_threads: 1 } | ||
| compiler: { name: gcc, flags: --cc=gcc } | ||
| - os: { name: windows, runner: windows-latest, shell: 'msys2 {0}', runner_threads: 1 } | ||
| compiler: { name: clang, flags: --cc=clang } | ||
| - os: { name: windows, runner: windows-latest, shell: 'msys2 {0}', runner_threads: 1 } | ||
| compiler: { name: clang-usan, flags: '--toolchain=clang-usan' } | ||
| - os: { name: windows, runner: windows-latest, shell: 'msys2 {0}', runner_threads: 1 } | ||
| compiler: { name: clang-asan, flags: '--toolchain=clang-asan' } | ||
|
|
||
| runs-on: ${{ matrix.os.runner }} | ||
| defaults: | ||
| run: | ||
| shell: ${{ matrix.os.shell }} | ||
|
|
||
| steps: | ||
| - name: Get MSVC | ||
| if: ${{ matrix.compiler.name == 'msvc' && matrix.os.name == 'windows' }} | ||
| uses: ilammy/msvc-dev-cmd@v1 | ||
|
|
||
| - name: Set up MSYS2 | ||
| if: ${{ matrix.os.shell == 'msys2 {0}' }} | ||
| uses: msys2/setup-msys2@v2 | ||
| with: | ||
| release: false | ||
| msystem: UCRT64 | ||
| path-type: inherit | ||
| install: >- | ||
| make | ||
| diffutils | ||
|
|
||
| - name: Setup python package | ||
| run: python3 -m pip install tqdm pyyaml | ||
|
|
||
| - name: Get assembler | ||
| if: ${{ matrix.os.shell == 'msys2 {0}' && matrix.assembler.name != 'no asm' }} | ||
| run: pacman --noconfirm -S ${{ matrix.assembler.name }} | ||
|
|
||
| - name: Get source | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| path: FFmpeg | ||
|
|
||
| - name: Configure | ||
| run: cd FFmpeg && ./configure ${{ matrix.compiler.flags }} ${{ matrix.assembler.flags }} ${{ env.configure_flags }} || (tail ffbuild/config.log; false) | ||
|
|
||
| - name: Build | ||
| run: cd FFmpeg && make -j8 | ||
|
|
||
| - name: Get tests | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| repository: ffvvc/tests | ||
| path: tests | ||
|
|
||
| - name: Unit test | ||
| run: python3 tests/tools/ffmpeg.py --threads ${{ matrix.os.runner_threads }} --ffmpeg-path=./FFmpeg/ffmpeg tests/conformance/passed | ||
|
|
||
| - name: Check ASM | ||
| run: cd FFmpeg && make checkasm -j && ./tests/checkasm/checkasm | ||
|
|
||
| - name: Negative test | ||
| run: python3 tests/tools/ffmpeg.py --threads ${{ matrix.os.runner_threads }} --ffmpeg-path=./FFmpeg/ffmpeg tests/conformance/failed || true | ||
|
|
||
| - name: Check for fuzz regressions | ||
| run: python3 tests/tools/ffmpeg.py --threads ${{ matrix.os.runner_threads }} --ffmpeg-path=./FFmpeg/ffmpeg --no-output-check --allow-decode-error tests/fuzz/passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember this will introduce some build errors for the window
could you "git cherry-pick ..ffvvc/workflow" and force-push your branch?
So we can now see the windows result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure, I also tried it on Windows and everything works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! please send to maling list for review.
thank you