Skip to content

ff_scoringhistory missing passing_yards for ESPN.  #432

Open
@aarizvi

Description

@aarizvi

Describe the bug
A clear and concise description of what the bug is.

Reprex
Please provide a short, reproducible example of the code you are trying to run.
For more on reprexes, check out https://reprex.tidyverse.org

library(ffscrapr)
conn <- espn_connect(
  season = 2023,
  league_id = # my league_id,
  espn_s2 = Sys.getenv("TAN_ESPN_S2"),
  swid = Sys.getenv("TAN_SWID")
)

scoring_history |>
    filter(season == "2023", week == 1, pos == "QB")  |>
    arrange(desc(points)) 


> scoring_history_2023 |> colnames()
 [1] "season"                    "week"                      "gsis_id"                   "sportradar_id"             "espn_id"                   "player_name"               "pos"                       "team"                      "points"                   
[10] "interceptions"             "passing_2pt_conversions"   "passing_tds"               "receiving_2pt_conversions" "receiving_fumbles_lost"    "receiving_tds"             "receiving_yards"           "rushing_2pt_conversions"   "rushing_fumbles_lost"     
[19] "rushing_tds"               "rushing_yards"             "sack_fumbles_lost"         "special_teams_tds"         "fg_made_0_19"              "fg_made_20_29"             "fg_made_30_39"             "fg_made_40_49"             "fg_made_50_59"            
[28] "fg_made_60_"               "fg_missed"                 "pat_made"          

Expected behavior
The points per player seemed off so I wanted to calculate it myself and noticed that the passing_yardsds field was missing. I see that field is listed here

Session information
Please copy the output of ffscrapr::ffverse_sitrep() into the box below.

> ffscrapr::ffverse_sitrep()
── System Info ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• R version 4.4.0 (2024-04-24) • Running under: macOS Ventura 13.2
── Package Status ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
        package installed  cran      dev behind
1 ffopportunity  0.1.0.06  <NA> 0.1.0.07    dev
2        ffpros     0.1.5  <NA>    0.1.5       
3      ffscrapr  1.4.8.18 1.4.8 1.4.8.18       
4   ffsimulator  1.2.3.01  <NA> 1.2.3.01       
── Package Options ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• ffpros.include_metadata: FALSEffpros.sport           : nflffpros.user_agent      : ffpros/0.1.5 R client package https://github.com/ffverse/ffpros
── Package Dependencies ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• askpass      (1.2.0)   • ipred      (0.9-15)      • recipes    (1.1.0)     
• assertthat   (0.2.1)   • janitor    (2.2.0)       • Rglpk      (0.6-5.1)   
• backports    (1.5.0)   • jsonlite   (1.8.8)       • rlang      (1.1.4)     
• cachem       (1.1.0)   • KernSmooth (2.23-22)     • rpart      (4.1.23)    
• checkmate    (2.3.2)   • lattice    (0.22-6)      • rvest      (1.0.4)     
• class        (7.3-22)  • lava       (1.8.0)       • selectr    (0.4-2)     
• cli          (3.6.3)   • lifecycle  (1.0.4)       • shape      (1.4.6.1)   
• clock        (0.7.1)   • listenv    (0.9.1)       • slam       (0.1-52)    
• codetools    (0.2-20)  • lubridate  (1.9.3)       • snakecase  (0.11.1)    
• compiler     (4.4.0)   • magrittr   (2.0.3)       • splines    (4.4.0)     
• cpp11        (0.4.7)   • MASS       (7.3-60.2)    • SQUAREM    (2021.1)    
• curl         (5.2.1)   • Matrix     (1.7-0)       • stats      (4.4.0)     
• data.table   (1.15.4)  • memoise    (2.0.1)       • stringi    (1.8.4)     
• diagram      (1.6.5)   • methods    (4.4.0)       • stringr    (1.5.1)     
• digest       (0.6.36)  • mime       (0.12)        • survival   (3.5-8)     
• dplyr        (1.1.4)   • nflreadr   (1.4.1)       • sys        (3.4.2)     
• fansi        (1.0.6)   • nnet       (7.3-19)      • tibble     (3.2.1)     
• fastmap      (1.2.0)   • numDeriv   (2016.8-1.1)  • tidyr      (1.3.1)     
• future       (1.34.0)  • openssl    (2.2.0)       • tidyselect (1.2.1)     
• future.apply (1.11.2)  • parallel   (4.4.0)       • timechange (0.3.0)     
• generics     (0.1.3)   • parallelly (1.38.0)      • timeDate   (4032.109)  
• globals      (0.16.3)  • pillar     (1.9.0)       • tools      (4.4.0)     
• glue         (1.7.0)   • pkgconfig  (2.0.3)       • tzdb       (0.4.0)     
• gower        (1.0.1)   • prodlim    (2024.06.25)  • utf8       (1.2.4)     
• graphics     (4.4.0)   • progressr  (0.14.0)      • utils      (4.4.0)     
• grDevices    (4.4.0)   • purrr      (1.0.2)       • V8         (4.4.2)     
• grid         (4.4.0)   • R6         (2.5.1)       • vctrs      (0.6.5)     
• hardhat      (1.4.0)   • rappdirs   (0.3.3)       • withr      (3.0.1)     
• hms          (1.1.3)   • ratelimitr (0.4.1)       • xgboost    (1.7.8.1)   
• httr         (1.4.7)   • Rcpp       (1.0.13)      • xml2       (1.3.6)     
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────```

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Additional context**
Add any other context about the problem here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions