Skip to content

Fix typo in migration docs #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

ludacirs
Copy link
Contributor

According to the link, the return value of the terminate() is not promise.
so i think we don't need that

public terminate = (): void => {

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for ffmpegwasm ready!

Name Link
🔨 Latest commit 7bcdf00
🔍 Latest deploy log https://app.netlify.com/sites/ffmpegwasm/deploys/678e6e55a74ae900081c48cb
😎 Deploy Preview https://deploy-preview-825--ffmpegwasm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@lucasgelfond lucasgelfond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks!

@lucasgelfond lucasgelfond merged commit 74ed993 into ffmpegwasm:main Apr 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants