-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for building on Windows and specifying custom boards #72
Conversation
Adjusted paths so that building will work on windows/powershell. Also changed default ncs version to 2.6.1 and fixed zigbee with changes related to it. We're also setting BOARD_ROOT to workdir so that one can use custom board definitions
The explanation for filepath.Dir to path.Dir in some parts of template can be found in this issue golang/go#44305 (comment) |
66f51f8
to
2fa8919
Compare
Hello @felipejfc, Thank you for the PR! I looked through it and it does look good to me. I will do some tests locally as well and post comments, if any, but generally have no objections for this PR.
|
Thank you very much for reviewing!
The reason I didn't have problems is probably that whenever I'm running zigbee_home binary, I'm doing it from inside a nrf shell environment with: |
Co-authored-by: Yevhen Sylenko <1863154+ffenix113@users.noreply.github.com>
Update: pushed a new commit fixing the file you pointed out and some more path separators. Now I can compile a firmware successfully even directly in powershell without needing to enter an ncs terminal first |
Could you please remove this, and I am ready to approve & merge this, unless you have anything else to discuss. Great work! |
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you!
(Draft PR for us to discuss the changes)
Adjusted paths so that the building will work on Windows/powershell. Also changed the default ncs version to 2.6.1 and fixed Zigbee with changes related to it.
I've included BOARD_ROOT pointing to workdir on the generated CMakeLists so that one can use custom boards by creating a boards dir alongside zigbee.yaml file, I can create example related to it but it's a great way for us to achieve broader compatibility and adoption. I used this capability it to compile the binary to a nice!nano board and it worked great.