Apply changes proposed in this [PR](xeipuuv#302) to fix the date-time…

… format being too permissive
fewlinesco · Jun 11, 2021 · 7460515 · 7460515
1 parent b076d39
commit 7460515
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/format_checkers.go b/format_checkers.go
@@ -230,9 +230,6 @@ func (f DateTimeFormatChecker) IsFormat(input interface{}) bool {
 	}
 
 	formats := []string{
-		"15:04:05",
-		"15:04:05Z07:00",
-		"2006-01-02",
 		time.RFC3339,
 		time.RFC3339Nano,
 	}

diff --git a/format_checkers_test.go b/format_checkers_test.go
@@ -26,6 +26,16 @@ func TestURIReferenceFormatCheckerIsFormat(t *testing.T) {
 	assert.True(t, checker.IsFormat("https://dummyhost.com/dummy-path?dummy-qp-name=dummy-qp-value"))
 }
 
+func TestDateTimeFormatCheckerIsFormat(t *testing.T) {
+	checker := DateTimeFormatChecker{}
+
+	assert.False(t, checker.IsFormat("2019-01-01"))
+	assert.False(t, checker.IsFormat("2019-01-01 10:00:00"))
+	assert.False(t, checker.IsFormat("2019-01-01T10:00:00"))
+	assert.True(t, checker.IsFormat("2019-01-01T10:00:00Z"))
+	assert.True(t, checker.IsFormat("2019-01-01T10:00:00.102Z"))
+}
+
 const formatSchema = `{
 	"type": "object",
 	"properties": {

diff --git a/testdata/draft7/optional/format/date-time.json b/testdata/draft7/optional/format/date-time.json
@@ -17,6 +17,11 @@
                 "description": "only RFC3339 not all of ISO 8601 are valid",
                 "data": "2013-350T01:01:01",
                 "valid": false
+            },
+            {
+                "description": "an invalid date-time string",
+                "data": "2020-01-01",
+                "valid": false
             }
         ]
     }