Skip to content

Conversation

Jonathansumner
Copy link
Member

@Jonathansumner Jonathansumner commented May 23, 2023

  • Nested contract-contract calls, e.g. an Execution message on one contract calling the instantiation of another, being obstructed by over-filtering of handler triggers.
    • In this example, the instantiation message would not be indexed, as it was called as part of an Execution message. With the previous heavy-handed message filtering, all instantiation calls required the event of type instantiation as well as the message typeUrl to be that of an instantiation.
  • Schema changed to reflect instantiateMsg optional properties, admin & label.
  • Removed leftover prints
  • Refactored handler config into module categories
  • Added genesis processor config to testing docker-compose.yml

Code Review Checklist (to be filled out by reviewer)

  • Description accurately reflects what changes are being made.
  • Either the PR references an issue (via the "Development" combobox) or the description explains the need for the changes.
  • The PR appropriately sized.
  • The PR contains an idempotent DB migration.
  • I have verified the correctness of the DB migration using relevant data (e.g. test-generated data).
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

@Jonathansumner Jonathansumner self-assigned this May 23, 2023
@Jonathansumner Jonathansumner enabled auto-merge (squash) May 23, 2023 16:19
Copy link

@pbukva pbukva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonathansumner Jonathansumner merged commit 86f593d into main May 24, 2023
@Jonathansumner Jonathansumner deleted the fix/update-contract-handler-filters branch May 24, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants