Skip to content

Conversation

MissingNO57
Copy link

@MissingNO57 MissingNO57 commented Mar 2, 2023

Using changes from #243

Replaced original genesis processing with the new one.

TODO:

  • Add contracts manager tests

Code Review Checklist (to be filled out by reviewer)

  • Description accurately reflects what changes are being made.
  • Either the PR references an issue (via the "Development" combobox) or the description explains the need for the changes.
  • The PR appropriately sized.
  • The PR contains an idempotent DB migration.
  • I have verified the correctness of the DB migration using relevant data (e.g. test-generated data).
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

@MissingNO57 MissingNO57 marked this pull request as ready for review March 3, 2023 12:55
@Jonathansumner Jonathansumner self-requested a review March 3, 2023 13:39
Copy link
Member

@Jonathansumner Jonathansumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice one!

@MissingNO57 MissingNO57 merged commit f1e4563 into main Mar 3, 2023
@MissingNO57 MissingNO57 deleted the feature/refactor_genesis_processing branch March 3, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants