Skip to content

chore: add open telemetry tracing #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 4, 2022
Merged

chore: add open telemetry tracing #157

merged 11 commits into from
Nov 4, 2022

Conversation

bryanchriswhite
Copy link

@bryanchriswhite bryanchriswhite commented Oct 28, 2022 •
edited
Loading

Changes

  • extract node-cosmos package (closed source) from onfinality/subql-node-cosmos image
  • add OpenTelemetry instrumentation to node-cosmos package
    • additional effort is required to trace through the vm2 sandbox environment (i.e. distinguishing our mapping handler functions)
  • add OpenTelemetry dependencies to subql-node-cosmos container
  • add package.json scripts to start (and stop) the tracing docker composition
  • add SigNoz stack to new tracing docker composition (path of least resistance)
    • in production environments, we will have to either:
      • replicate this in helm charts
      • (or) reconfigure OpenTelemetry to report to existing grafana / prometheus / loki stack

image

image

@bryanchriswhite bryanchriswhite self-assigned this Oct 31, 2022
@bryanchriswhite bryanchriswhite linked an issue Oct 31, 2022 that may be closed by this pull request
Performance analysis #150
Closed
@bryanchriswhite bryanchriswhite marked this pull request as ready for review November 3, 2022 13:55
Jonathansumner
Jonathansumner previously approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@Jonathansumner Jonathansumner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, Bryan!

Jonathansumner
Jonathansumner previously approved these changes Nov 4, 2022
View reviewed changes
@bryanchriswhite bryanchriswhite enabled auto-merge (squash) November 4, 2022 10:40
@bryanchriswhite bryanchriswhite merged commit 1c9bf5d into main Nov 4, 2022
@bryanchriswhite bryanchriswhite deleted the chore/tracing branch November 4, 2022 10:41
@bryanchriswhite
Copy link
Author

Not sure why auto-merge decided to go ahead before CI finished... 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonathansumner Jonathansumner Jonathansumner approved these changes

@ejfitzgerald ejfitzgerald Awaiting requested review from ejfitzgerald

Assignees

@bryanchriswhite bryanchriswhite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance analysis
2 participants
@bryanchriswhite @Jonathansumner