Introduce combined sigs commit #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinmannwong
reviewed
Nov 3, 2020
| @@ -50,6 +52,10 @@ func NewMsgCreateValidator( | |||
| description Description, commission CommissionRates, minSelfDelegation sdk.Int, | |||
| ) MsgCreateValidator { | |||
|
|
|||
| if _, ok := pubKey.(bls12_381.PubKeyBls); !ok && pubKey != nil { | |||
| panic(fmt.Sprintf("Attempt to create validator with non bls based public key is invalid!\n")) | |||
There was a problem hiding this comment.
I don't know if this should be a panic. Should we not just reject the msg when the MsgCreateValidator is handled?
There was a problem hiding this comment.
It does not need to be a panic, it is quite useful when making the switch to find out when code has tried to create an incorrect validator. I can remove it if you like?
There was a problem hiding this comment.
No, that's fine. I agree it is useful when switching to keep this.
jinmannwong
reviewed
Nov 3, 2020
| @@ -156,7 +158,7 @@ func TestSlashingMsgs(t *testing.T) { | |||
| require.Equal(t, sdk.ValAddress(addr1), validator.OperatorAddress) | |||
| require.Equal(t, sdk.Bonded, validator.Status) | |||
| require.True(sdk.IntEq(t, bondTokens, validator.BondedTokens())) | |||
| unjailMsg := MsgUnjail{ValidatorAddr: sdk.ValAddress(validator.ConsPubKey.Address())} | |||
| unjailMsg := MsgUnjail{ValidatorAddr: validator.OperatorAddress} | |||
There was a problem hiding this comment.
Why did this need to change?
There was a problem hiding this comment.
The address that is signing the unjail message should be the 'operating address' of the validator, which is not related to its consensus public key (now bls).
jinmannwong
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.