Refactor delaying of staking updates #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinmannwong
commented
Aug 6, 2020
| @@ -0,0 +1,29 @@ | |||
| package keeper | |||
|
|
|||
There was a problem hiding this comment.
Main changes are the refactoring of validator update delay checks into this file.
ejfitzgerald
reviewed
Aug 6, 2020
x/staking/handler_test.go
Outdated
| EndBlocker(ctx, &keeper) | ||
| BeginBlocker(ctx, abci.RequestBeginBlock{Header: header}, keeper) | ||
| EndBlocker(ctx, keeper) | ||
| EndBlocker(ctx, keeper) |
There was a problem hiding this comment.
Double end blocker - intentional?
There was a problem hiding this comment.
It was in the original test, but the test seems to run fine without it so it was probably just a typo.
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| ) | ||
|
|
||
| var ( |
There was a problem hiding this comment.
does it makes sense for this to be const
There was a problem hiding this comment.
Yes, that would be better.
ejfitzgerald
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor delaying of staking updates into own file to minimise changes to other sdk modules