Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Municipal Inflation: cache redesign atomic + simtest #166

Merged

Conversation

pbukva
Copy link
Contributor

@pbukva pbukva commented Aug 10, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #166 (b48cc8b) into feat/municipal-inflation (f661c3b) will increase coverage by 0.00%.
The diff coverage is 33.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           feat/municipal-inflation     #166   +/-   ##
=========================================================
  Coverage                     60.50%   60.51%           
=========================================================
  Files                           599      599           
  Lines                         38883    38885    +2     
=========================================================
+ Hits                          23528    23530    +2     
  Misses                        13374    13374           
  Partials                       1981     1981           
Files Changed Coverage Δ
x/mint/types/minter.go 71.42% <0.00%> (-3.58%) ⬇️
x/mint/genesis.go 57.14% <100.00%> (+7.14%) ⬆️

... and 1 file with indirect coverage changes

@pbukva pbukva merged commit 49044fc into feat/municipal-inflation Aug 11, 2023
25 checks passed
@pbukva pbukva deleted the fix/municipal-inflation-cache-singleton branch August 11, 2023 07:33
Copy link
Member

@Jonathansumner Jonathansumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on my end, nice one!

pbukva added a commit that referenced this pull request Aug 12, 2023
* feat: Municipal Inflation MVP (#153)

* fix: Municipal Inflation: list->map & cli command printout (#154)

* fix: Municipal Inflation: grpc query error check (#155)

* fix: Municipal Inflation: cli tests for query with denom (#156)

* fix: [WIP] Municipal Inflation determinism(map->list), cache redesign (#159)

* [Cosmetic]: Municipal Inflation Cache: update code comment (#163)

* fix: [Cosmetic] Go linting (#164)

* fix: [Cosmetic] Go linting
* CI test run - setting golang v1.18.10

* fix: Municipal Inflation: protobuf yaml tag naming (#165)

* fix: Municipal Inflation: cache redesign atomic + simtest (#166)

* feat: Municipal Inflation: Handler optimisation & Validation fix (#167)

---------

Co-authored-by: void* <peter.bukva@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants