Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial Municipal Inflations #150

Merged
merged 32 commits into from
Jun 29, 2023
Merged

Conversation

Jonathansumner
Copy link
Member

@Jonathansumner Jonathansumner commented Jun 14, 2023

Introduces Municiple Inflation, allowing native tokens to have individually specified inflation rates and 'fee-collector' accounts.

  • Each of these MunicipalInflation objects will be used to inflate the relevant supply per block and distribute the new tokens to the fee-collector address.
  • Includes a number of tests providing coverage to this new mechanism.

Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Jonathansumner and others added 5 commits June 21, 2023 10:38
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
…nto feat/inflation-infrastructure

# Conflicts:
#	x/mint/types/inflations_test.go
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
x/mint/types/inflations.go Outdated Show resolved Hide resolved
x/mint/types/inflations.go Outdated Show resolved Hide resolved
x/mint/types/inflations.go Outdated Show resolved Hide resolved
x/mint/types/inflations.go Outdated Show resolved Hide resolved

// Assert tokens reached account
testAccountBalance := app.BankKeeper.GetBalance(ctx, acc, tc.inflation.Denom)
require.Equal(t, tc.expectedBalance.Int64(), testAccountBalance.Amount.Int64())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, we should not convert balances to uint64, compare directly native types of balance values.

Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
@Jonathansumner Jonathansumner changed the base branch from feat/inflations-support to main June 27, 2023 15:58
x/mint/types/inflations.go Outdated Show resolved Hide resolved
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Copy link
Contributor

@pbukva pbukva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as MVP (it will need subsequent improvements and additional tests)

@Jonathansumner Jonathansumner merged commit 6de810c into main Jun 29, 2023
@Jonathansumner Jonathansumner deleted the feat/inflation-infrastructure branch June 29, 2023 18:30
@pbukva pbukva restored the feat/inflation-infrastructure branch June 29, 2023 23:09
@Jonathansumner Jonathansumner changed the title feat: initial native inflations infrastructure feat: Initial Municipal Inflations Jun 30, 2023
Jonathansumner added a commit that referenced this pull request Jun 30, 2023
@pbukva pbukva deleted the feat/inflation-infrastructure branch June 30, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants