This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
Bug fix add txs to peer priority txs #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinmannwong
commented
Sep 24, 2020
| // Priority txs are gossiped using peer pointer priority txs so we to do not include | ||
| // them here to avoid sending duplicates | ||
| if _, ok := memTx.senders.Load(peerID); !ok && !isPriority(memTx.tx) { | ||
| if _, ok := memTx.senders.Load(peerID); !ok { |
There was a problem hiding this comment.
Removed check for isPriority as sometimes a peer does not yet exist when DKG txs are added to mempool. Removing this check allows these txs to be included from the main mempool queue. Since DKG transactions are appended in the front of the queue there will not be many duplicates in the gossip beyond the first few transactions.
There was a problem hiding this comment.
Sure. Is this just fixing the corner case when the network starts for the first time?
jinmannwong
commented
Sep 24, 2020
| _, err := rand.Read(txBytes) | ||
| if err != nil { | ||
| t.Error(err) | ||
| } | ||
| txBytes = tx_extensions.PrependBytes(txBytes) // Convert to priority tx (dkg) | ||
| assert.True(t, isPriority(txBytes)) | ||
| txs[i] = txBytes |
There was a problem hiding this comment.
Having rand after the prepend was messing up prefix and made the tx no longer a priority tx
n-hutton
approved these changes
Sep 24, 2020
| // Priority txs are gossiped using peer pointer priority txs so we to do not include | ||
| // them here to avoid sending duplicates | ||
| if _, ok := memTx.senders.Load(peerID); !ok && !isPriority(memTx.tx) { | ||
| if _, ok := memTx.senders.Load(peerID); !ok { |
There was a problem hiding this comment.
Sure. Is this just fixing the corner case when the network starts for the first time?
| _, err := rand.Read(txBytes) | ||
| if err != nil { | ||
| t.Error(err) | ||
| } | ||
| txBytes = tx_extensions.PrependBytes(txBytes) // Convert to priority tx (dkg) | ||
| assert.True(t, isPriority(txBytes)) | ||
| txs[i] = txBytes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix to allow appending of dkg txs to peerPointer. Removed filtering of priority txs in GetNewTxs when getting transactions from main txs queue.