Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates to various tools (makefile, tox, templates, docs, ...) #2816

Merged
merged 10 commits into from
Nov 29, 2022

Conversation

5A11
Copy link
Member

@5A11 5A11 commented Nov 21, 2022

Proposed changes

This PR makes sweeping updates across the AEA framework. Amongst them:

  • updates issues and PR templates
  • updates GH actions in workflows to latest versions and pins to versions (instead of master)
  • removes docker images submodule
  • moves every tool's configurations (whee supported) into pyproject.toml and removes standalone config files
  • update repo documentation markdown files (CONTRIBUTING, CODE OF CONDUCT, README, AUTHORS)
  • makes significant updates to makefile commands
  • updates project meta-data in pyproject.toml
  • updates tox to use makefile commands

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@5A11 5A11 changed the title update 1 [WIP] AEA framework review + improvements Nov 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2022

Codecov Report

Merging #2816 (fa3e58d) into develop (edb3e95) will increase coverage by 0.19%.
The diff coverage is 100.00%.

❗ Current head fa3e58d differs from pull request most recent head d0307f5. Consider uploading reports for the commit d0307f5 to get more accurate results

@@             Coverage Diff             @@
##           develop    #2816      +/-   ##
===========================================
+ Coverage    97.90%   98.10%   +0.19%     
===========================================
  Files          503      503              
  Lines        35849    35849              
===========================================
+ Hits         35098    35168      +70     
+ Misses         751      681      -70     
Flag Coverage Δ
unittests 98.10% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aea/protocols/generator/common.py 100.00% <ø> (ø)
aea/helpers/serializers.py 100.00% <100.00%> (ø)
packages/fetchai/contracts/erc1155/contract.py 100.00% <100.00%> (ø)
aea/cli/run.py 100.00% <0.00%> (+16.66%) ⬆️
aea/cli/interact.py 100.00% <0.00%> (+34.73%) ⬆️
aea/cli/launch.py 100.00% <0.00%> (+50.00%) ⬆️
aea/cli/__main__.py 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

.gitmodules Show resolved Hide resolved
.pylintrc Show resolved Hide resolved
Makefile Show resolved Hide resolved
README.md Show resolved Hide resolved
protolint.yaml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
tox.ini Show resolved Hide resolved
tox.ini Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@5A11 5A11 marked this pull request as ready for review November 28, 2022 08:25
CONTRIBUTING.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@solarw solarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
couple of comments only

@5A11 5A11 requested review from solarw and jrriehl November 28, 2022 11:41
Copy link
Contributor

@solarw solarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@5A11 5A11 changed the title [WIP] AEA framework review + improvements AEA framework review + improvements Nov 29, 2022
@5A11 5A11 changed the title AEA framework review + improvements chore: updates to project structure Nov 29, 2022
@5A11 5A11 changed the title chore: updates to project structure chore: updates to various tools (makefile, tox, templates, docs, ...) Nov 29, 2022
@5A11 5A11 merged commit 1ed8620 into develop Nov 29, 2022
@5A11 5A11 deleted the chore/cleanup branch November 29, 2022 08:36
@5A11 5A11 linked an issue Dec 5, 2022 that may be closed by this pull request
@5A11 5A11 mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and improve Makefile
4 participants