Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aea autocompletition speed up #2647

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

solarw
Copy link
Contributor

@solarw solarw commented Oct 6, 2021

Proposed changes

aea autocompletition speed up

all the import changes are required, to make it lazy style and avoid extra modules loaded during cli completition work

Fixes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@solarw solarw force-pushed the fix/aea_autocompletition_speedup branch from a9f9560 to 643ff29 Compare October 6, 2021 08:37
@solarw solarw force-pushed the fix/aea_autocompletition_speedup branch from 643ff29 to c2c3f65 Compare October 6, 2021 11:02
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #2647 (ae46fe2) into develop (0433b04) will increase coverage by 1.10%.
The diff coverage is 52.63%.

❗ Current head ae46fe2 differs from pull request most recent head 8d35490. Consider uploading reports for the commit 8d35490 to get more accurate results

@@             Coverage Diff             @@
##           develop    #2647      +/-   ##
===========================================
+ Coverage    98.46%   99.56%   +1.10%     
===========================================
  Files          522      523       +1     
  Lines        36296    36409     +113     
===========================================
+ Hits         35738    36252     +514     
+ Misses         558      157     -401     
Flag Coverage Δ
unittests 99.56% <52.63%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aea/__init__.py 100.00% <ø> (ø)
aea/cli/utils/autocompletition.py 45.45% <45.45%> (ø)
aea/cli/__init__.py 100.00% <100.00%> (ø)
aea/configurations/base.py 100.00% <100.00%> (ø)
aea/crypto/__init__.py 100.00% <100.00%> (ø)
aea/crypto/plugin.py 100.00% <100.00%> (ø)
aea/cli/run.py 83.33% <0.00%> (-1.12%) ⬇️
aea/launcher.py 100.00% <0.00%> (ø)
aea/multiplexer.py 100.00% <0.00%> (ø)
aea/mail/base_pb2.py 100.00% <0.00%> (ø)
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0433b04...8d35490. Read the comment docs.

@solarw
Copy link
Contributor Author

solarw commented Oct 28, 2021

good to be merged

@solarw
Copy link
Contributor Author

solarw commented Feb 14, 2022

reviewed

@solarw solarw force-pushed the fix/aea_autocompletition_speedup branch 2 times, most recently from 2be8fa5 to 624ffab Compare March 25, 2022 12:43
@solarw solarw force-pushed the fix/aea_autocompletition_speedup branch from 624ffab to cf752c2 Compare March 25, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants