Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cards on front page of docs #890

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Cards on front page of docs #890

merged 5 commits into from
Oct 25, 2024

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

Attempt at improving the front page of the documentation.

I have added clickable cards that look like this:

image

@KulaginVladimir @jhdark feel free to comment

Should fix #850

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (abe3942) to head (c551da3).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #890   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          61       61           
  Lines        2750     2778   +28     
=======================================
+ Hits         2738     2766   +28     
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KulaginVladimir
Copy link
Collaborator

is it possible to shift icon+text blocks to the center (along the vertical)?

@RemDelaporteMathurin
Copy link
Collaborator Author

is it possible to shift icon+text blocks to the center (along the vertical)?

Are they not already centered?

image

@KulaginVladimir
Copy link
Collaborator

image

@RemDelaporteMathurin
Copy link
Collaborator Author

Oh, didn't notice this. Not sure how to do this, maybe by tweaking the CSS?

@KulaginVladimir
Copy link
Collaborator

If it's complicated, then doesn't matter)

@shimwell
Copy link
Contributor

Is it possible to test this on a mobile resolution

@RemDelaporteMathurin
Copy link
Collaborator Author

Is it possible to test this on a mobile resolution

It's all in one column on my mobile phone

@RemDelaporteMathurin
Copy link
Collaborator Author

@shimwell the latest commit ensures there are three columns for all screen sizes. Would you prefer it that way or a single column for small screens?

@RemDelaporteMathurin RemDelaporteMathurin merged commit 7dbfedf into main Oct 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: add link to V&V book
3 participants