-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multispecies support #617
Merged
RemDelaporteMathurin
merged 82 commits into
festim-dev:fenicsx
from
jhdark:multispecies_support
Oct 26, 2023
Merged
Multispecies support #617
RemDelaporteMathurin
merged 82 commits into
festim-dev:fenicsx
from
jhdark:multispecies_support
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into multispecies_support
jhdark
added
enhancement
New feature or request
fenicsx
Issue that is related to the fenicsx support
labels
Oct 20, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #617 +/- ##
===========================================
+ Coverage 97.47% 98.17% +0.70%
===========================================
Files 16 16
Lines 475 549 +74
===========================================
+ Hits 463 539 +76
+ Misses 12 10 -2
☔ View full report in Codecov by Sentry. |
…species Refactoring bc multispecies
RemDelaporteMathurin
requested changes
Oct 25, 2023
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
… into multispecies_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
With these series of changes, festim will support multispecies transport. This also will provide the foundation for future festim.Reactions() class to be implemented. With this, users can simulate the simultaneous transport of multiple mobile species.
The species being modelled will have to be given as a list of festim.species objects:
The diffusion properties of each species will need to be given as a dictionary within the festim.Material object.
Keys within this dictionary can either be the name of the species as a string, or the species object.
The species will also have to be defined within the boundary conditions and exports:
Again, species can either be given as the string name assigned or the species object itself.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...