[Refactor] Dev 환경 이미지 S3 방향 전환 #7

taek2222 · 2025-11-27T15:24:52Z

#️⃣ 이슈 번호

#6

🛠️ 작업 내용

Dev 환경 이미지 저장을 기존 로컬 방식에서 S3로 변경했습니다.
Secret YML 은 변경 완료해놨습니다.

coderabbitai · 2025-11-27T15:24:57Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)

android
backend
frontend

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Note

`.coderabbit.yaml` has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'tools'

⚙️ Configuration instructions

Please see the configuration documentation for more information.
You can also validate your configuration using the online YAML validator.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch refactor/6

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR refactors the dev environment to use S3 storage instead of local file storage, aligning it with the production environment's approach.

Key Changes:

Enabled S3StorageManager for both prod and dev profiles
Deprecated LocalStorageManager with documentation explaining the change

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
S3StorageManager.java	Updated @Profile annotation to include dev environment alongside prod
LocalStorageManager.java	Marked as deprecated with explanatory comments, removed profile restriction

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/main/java/com/daedan/festabook/storage/infrastructure/S3StorageManager.java

Copilot · 2025-11-27T15:28:48Z

src/main/java/com/daedan/festabook/storage/infrastructure/LocalStorageManager.java

+/*
+  날짜 : 2025/11/27
+  Dev 환경 로컬 저장 방식에서 S3 방식으로 변경되어 사용하지 않게 되었습니다.
+  하지만, 추후 로컬에서 사용할 수 있는 가능성이 있어 남겨둡니다.


The deprecation comment uses the wrong comment style. For a multi-line comment explaining deprecation in Java, use Javadoc style (/** ... */) instead of block comment style (/* ... */).

This allows better documentation generation and IDE integration. Consider:

/** * @deprecated 날짜 : 2025/11/27 * Dev 환경 로컬 저장 방식에서 S3 방식으로 변경되어 사용하지 않게 되었습니다. * 하지만, 추후 로컬에서 사용할 수 있는 가능성이 있어 남겨둡니다. */

Suggested change

/*

날짜 : 2025/11/27

Dev 환경 로컬 저장 방식에서 S3 방식으로 변경되어 사용하지 않게 되었습니다.

하지만, 추후 로컬에서 사용할 수 있는 가능성이 있어 남겨둡니다.

/**

* @deprecated 날짜 : 2025/11/27

* Dev 환경 로컬 저장 방식에서 S3 방식으로 변경되어 사용하지 않게 되었습니다.

* 하지만, 추후 로컬에서 사용할 수 있는 가능성이 있어 남겨둡니다.

src/main/java/com/daedan/festabook/storage/infrastructure/LocalStorageManager.java

changuii

코멘트 확인해주세요!

changuii · 2025-11-29T08:33:54Z

src/main/java/com/daedan/festabook/storage/infrastructure/LocalStorageManager.java

 @Slf4j
 @Loggable
 @Component
-@Profile("dev")
+@Deprecated(since = "2025/11/27")
+/**
+ * @Deprecated 날짜 : 2025/11/27
+ * Dev 환경 로컬 저장 방식에서 S3 방식으로 변경되어 사용하지 않게 되었습니다.
+ * 하지만, 추후 로컬에서 사용할 수 있는 가능성이 있어 남겨둡니다.
+ */
 public class LocalStorageManager implements StorageManager {


이거 @Componenet 어노테이션을 제거해야 LocalStorageManager가 정상적으로 dev, prod 환경에서 주입이 되지 않을 것 같아요
현재 코드를 보면 모든 프로파일에서 빈으로 등록되고 있습니다!

@Componenet 어노테이션 제거 했습니다. 꼼꼼한 리뷰 감사합니다!

eoehd1ek

코멘트 확인해주세요~

eoehd1ek · 2025-11-29T12:49:59Z

src/main/java/com/daedan/festabook/storage/infrastructure/LocalStorageManager.java

-@Profile("dev")
+@Deprecated(since = "2025/11/27")
+/**
+ * @Deprecated 날짜 : 2025/11/27
+ * Dev 환경 로컬 저장 방식에서 S3 방식으로 변경되어 사용하지 않게 되었습니다.
+ * 하지만, 추후 로컬에서 사용할 수 있는 가능성이 있어 남겨둡니다.
+ */


@Deprecated 어노테이션을 적용해도 스프링이 LocalStorageManager 컴포넌트를 빈으로 등록할 것 같습니다.
@Profile 어노테이션이 삭제되면 모든 프로필 상황에서 빈이 로드되니 S3StorageManager와 충돌이 날 것 같습니다.
아예 파일을 삭제하는 건 어떤가요?

맥에서 실행하는 local 환경에서는 MockStorageManager가 빈 등록되어 큰 문제는 없어보입니다.

삭제하는 방향으로 할까요? 언제 로컬에 저장할 지 몰라서 임시로 제거해둔 건데, 팀원들 의견 들어보고 결정합시다!

taek2222 · 2025-12-02T11:32:06Z

refactor: 프로필 dev 추가

해당 파일에 dev를 추가했습니다. dev ci-cd 하면서 이 부분도 같이 @Profile 설정을 해야한다는 점을 알게되어 적용했습니다.

changuii

LGTM

taek2222 added 2 commits November 28, 2025 00:17

refactor: 사용하지 않게 된 클래스 정리

9badbc9

refactor: dev 환경 S3 사용 변경

3411887

taek2222 requested review from changuii, Copilot, eoehd1ek and soeun2537 November 27, 2025 15:24

taek2222 self-assigned this Nov 27, 2025

taek2222 added the Refactor label Nov 27, 2025

Copilot started reviewing on behalf of taek2222 November 27, 2025 15:25 View session

Copilot finished reviewing on behalf of taek2222 November 27, 2025 15:25

Copilot AI reviewed Nov 27, 2025

View reviewed changes

soeun2537 approved these changes Nov 29, 2025

View reviewed changes

src/main/java/com/daedan/festabook/storage/infrastructure/LocalStorageManager.java Outdated Show resolved Hide resolved

refactor: 주석 날짜와 어노테이션 의미 추가

140d42f

changuii approved these changes Nov 29, 2025

View reviewed changes

src/main/java/com/daedan/festabook/storage/infrastructure/LocalStorageManager.java Show resolved Hide resolved

changuii requested changes Nov 29, 2025

View reviewed changes

eoehd1ek requested changes Nov 29, 2025

View reviewed changes

taek2222 added 2 commits December 2, 2025 20:30

refactor: 컴포넌트 어노테이션 삭제

59caef3

refactor: 프로필 dev 추가

3f0db20

taek2222 requested review from changuii and eoehd1ek December 2, 2025 11:32

changuii approved these changes Dec 2, 2025

View reviewed changes

eoehd1ek approved these changes Dec 3, 2025

View reviewed changes

taek2222 merged commit 70858f9 into dev Dec 3, 2025
5 checks passed

taek2222 deleted the refactor/6 branch December 3, 2025 13:51

[Refactor] Dev 환경 이미지 S3 방향 전환 #7

[Refactor] Dev 환경 이미지 S3 방향 전환 #7

Uh oh!

Conversation

taek2222 commented Nov 27, 2025

#️⃣ 이슈 번호

🛠️ 작업 내용

Uh oh!

coderabbitai bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

.coderabbit.yaml has unrecognized properties

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

changuii left a comment

Choose a reason for hiding this comment

Uh oh!

changuii Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

taek2222 Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

eoehd1ek left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eoehd1ek Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

taek2222 Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

taek2222 commented Dec 2, 2025

Uh oh!

changuii left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai bot commented Nov 27, 2025 •

edited

Loading

`.coderabbit.yaml` has unrecognized properties

eoehd1ek left a comment •

edited

Loading