fix(macos): prevent bidirectional capture loops - #473
Open
mrcha033 wants to merge 1 commit into
Open
Conversation
mrcha033
marked this pull request as ready for review
July 27, 2026 13:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a bidirectional Linux/Wayland ↔ macOS setup, Lan Mouse's macOS event tap
observes the pointer events posted by its own emulation backend. A synthesized
edge event can therefore be mistaken for a new local capture and immediately
send the pointer back, producing an Arch → macOS → Arch capture loop.
Changes
fallback when CoreGraphics does not preserve the tag
so short reversals work
EnterOnlycapturewhile preserving normal default capture for chained topologies
bounded event delivery
Validation
cargo fmt --all -- --checkcargo test --workspace --all-features --lockedcargo clippy -p input-capture --all-targets --all-features --locked -- -D warnings3d202975@rpathdependency closure andcodesign --verify --deep --strictpass locally
Physical Arch → macOS → Arch verification is still running against the Arch
binary from #471 (
83e66bc), so this is a draft.Scope
CoreGraphics event provenance is left for a follow-up
This is independent of #471, which contains the input post-processing changes.