Open
Conversation
ferranrecio
force-pushed
the
MDL-83869-main
branch
from
96c075b to
121886d
Compare
ferranrecio
force-pushed
the
MDL-83869-main
branch
from
121886d to
53886ac
Compare
ferranrecio
commented
Jan 22, 2025
| And I am on fixture page "/lib/tests/behat/fixtures/collapsable_section_output_testpage.php" | ||
|
|
||
| Scenario: Collapsable sections can be opened and closed | ||
| Given I should not see "Dialog content" |
Owner
Author
There was a problem hiding this comment.
This step is moved from background to the first scenario to test it only ones.
There was a problem hiding this comment.
Thanks for changing it. I know it's a little thing, but improves the performance a bit :-)
ferranrecio
commented
Jan 22, 2025
| Scenario: Collapsable sections can be controlled via javascript | ||
| # Toggle. | ||
| Given I should not see "This is the javascript controls content." in the "jscontrols" "region" | ||
| When I click on "Toggle" "button" in the "jscontrols" "region" |
ferranrecio
commented
Jan 22, 2025
|
|
||
| const section = CollapsableSection.instanceFromSelector('#MyCollapsableSection'); | ||
|
|
||
| if (section.isVisible()) { |
Owner
Author
There was a problem hiding this comment.
typo on isVisible fixed
ferranrecio
commented
Jan 22, 2025
| ### Events | ||
|
|
||
| The collapsable sections component also includes a JavaScript module for handling events. This module wraps the standard Bootstrap collapsable events and provides custom event types for collapsable sections. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request to support MDL-83869 review.