Update tailgate-allow@.service with PMTUD support#3
Update tailgate-allow@.service with PMTUD support#3bencorrado wants to merge 1 commit intofernandoenzo:masterfrom
Conversation
I was seeing failures for routing large packets where the auto negotiation by PMTUD would normally cause the MSS to be adjusted for the overhead. With the rules in allow ICMP was blocked by the firewall rules, so there was no PMTUD happening. This opens the right connections for ICMP to allow PMTUD to negotiate the packet sizes.
|
Hi! Thank you very much for taking the time to use my project, for your feedback, and for wanting to contribute. However, I think your pull request is not necessary because after carefully analyzing the existing firewall rules: Looking at Tailgate's implementation:
iptables -I OUTPUT -j tailgate
iptables -A tailgate -p udp --sport $PORT -j DROPThis rule specifically:
Therefore, the rules you're proposing are unnecessary since:
Tailgate's original rules are specifically designed to force Tailscale's UDP traffic to exit only through a specific interface, without affecting any other type of traffic. Therefore, while I appreciate your contribution, adding these rules would unnecessarily complicate the service without providing any benefit to its operation. Of course, if you think I'm wrong and want to explain to me the reasons why I should incorporate your lines into the project, I'm all ears. Otherwise, I could suggest that you incorporate your rules into a separate systemd unit, independent of Tailgate, to handle the use case you propose. Thank you again for your interest in improving the project! |
I was seeing failures for routing large packets where the auto negotiation by PMTUD would normally cause the MSS to be adjusted for the overhead. With the rules in allow ICMP was blocked by the firewall rules, so there was no PMTUD happening. This opens the right connections for ICMP to allow PMTUD to negotiate the packet sizes.