fix(pure_rust): restore Firebird 2.5 support broken by #177 - #182
Open
maratth wants to merge 1 commit into
Open
Conversation
…ytes Firebird 2.5 server reads the DPB with single-byte lengths only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #177 (c5ab7c3),
attachfails on Firebird 2.5 with:The DPB builder selected the wide clumplet format (
isc_dpb_version2, 4-bytelengths) whenever every parameter was shorter than 255 bytes — the condition
was inverted, and that format only exists since Firebird 3.0. Firebird 2.5 reads
the DPB with single-byte lengths, so its parser desynchronised immediately. The
other branch was broken too: it emitted version 1 with a length truncated to
u8.Fixed by selecting the wide format only when a parameter actually exceeds 255
bytes. Every value the driver sends is well under that, so both 2.5 and 3+ now
receive a version 1 DPB, as before #177.
Tested against Firebird 2.5 with the
pure_rustbackend.