Open
Conversation
Co-Authored-By: thomas@buildwithfern.com <tjb9dcshop@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs: Slack thread about AsyncAPI parsing failures being silently skipped
Previously, when an AsyncAPI document failed to parse, it was logged at debug level with "Skipping parsing document" and the CLI continued. This made it easy to miss configuration issues. Now, AsyncAPI parsing failures will cause
fern checkand generation to fail with an error.Link to Devin run: https://app.devin.ai/sessions/69b905a8948a427485624f081ccc25f4
Requested by: @tjb9dc
Changes Made
parse.ts- errors now propagate upOpenAPILoader.ts- loading failures now propagate upTesting
Human Review Checklist