Skip to content

fix(cli): make AsyncAPI parsing failures fatal#12101

Open
tjb9dc wants to merge 1 commit intomainfrom
devin/1770302824-asyncapi-fatal-parse-error
Open

fix(cli): make AsyncAPI parsing failures fatal#12101
tjb9dc wants to merge 1 commit intomainfrom
devin/1770302824-asyncapi-fatal-parse-error

Conversation

@tjb9dc
Copy link
Collaborator

@tjb9dc tjb9dc commented Feb 5, 2026

Description

Refs: Slack thread about AsyncAPI parsing failures being silently skipped

Previously, when an AsyncAPI document failed to parse, it was logged at debug level with "Skipping parsing document" and the CLI continued. This made it easy to miss configuration issues. Now, AsyncAPI parsing failures will cause fern check and generation to fail with an error.

Link to Devin run: https://app.devin.ai/sessions/69b905a8948a427485624f081ccc25f4
Requested by: @tjb9dc

Changes Made

  • Removed try-catch around AsyncAPI parsing in parse.ts - errors now propagate up
  • Removed try-catch around AsyncAPI loading in OpenAPILoader.ts - loading failures now propagate up
  • OpenAPI parsing behavior unchanged (still logs and skips on failure)
  • Added version 3.64.3 changelog entry

Testing

  • Unit tests added/updated
  • Manual testing completed (lint checks pass)

Human Review Checklist

  • Verify this is a breaking change for users with invalid AsyncAPI documents that were previously silently skipped
  • Confirm the asymmetric behavior is intentional: AsyncAPI failures are now fatal, while OpenAPI failures still skip silently
  • Consider if users need a way to opt-out of this stricter behavior

Co-Authored-By: thomas@buildwithfern.com <tjb9dcshop@gmail.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant