fix(docs): remove prefetched.files optimization to fix stale file data #5709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The batchGetCommonMetadata prefetch reads directly from KV and does not respect revalidateTag cache invalidation. This caused stale file data to be served after revalidation, resulting in mdx_unresolved_file_ids errors where file: IDs in markdown didn't match available files. By always calling getFiles() which has unstable_cacheTag, we ensure file resolution respects revalidateTag invalidation. Co-Authored-By: kenny@buildwithfern.com <kenny@buildwithfern.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
kennyderek
approved these changes
Dec 6, 2025
3 tasks
tsbhangu
pushed a commit
that referenced
this pull request
Dec 8, 2025
#5709) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: kenny@buildwithfern.com <kenny@buildwithfern.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Devin run: https://app.devin.ai/sessions/97c785c20bfd40f592b8d50a107c09db
Requested by: kenny@buildwithfern.com
Short description of the changes made
Removes the
prefetched.filesoptimization increateCachedDocsLoaderImpl.getFiles()and always callsgetFiles(config)(domainKey)directly.What was the motivation & context behind this PR?
Since Tuesday Dec 3, we've been seeing
mdx_unresolved_file_idserrors wherefile:IDs in markdown don't match available files infilesV2. The previous revert (#5706) removedloadDocsBranch/loadDocsResponsebut did NOT remove theprefetchPromiseoptimization.Root cause:
batchGetCommonMetadatareads directly from KV viakvMgetand does NOT respectrevalidateTagcache invalidation. Whenloader.getFiles()was called, it returnedprefetched.filesif non-null, bypassing thegetFilesfunction which hasunstable_cacheTag(domainKey, "getFiles"). This caused stale file data to be served after revalidation.By always calling
getFiles()which hasunstable_cacheTag, we ensure file resolution respectsrevalidateTaginvalidation.How has this PR been tested?
getFilespath; other prefetch optimizations (metadata, config, root, etc.) remain intactmdx_unresolved_file_idserrors stop occurringHuman review checklist
batchGetCommonMetadatadoesn't respectrevalidateTaggetFiles()has its own caching viaunstable_cacheTag)mdx_unresolved_file_idserrors stop