Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added HTTP webhook validation to spin SDK #502

Closed
wants to merge 4 commits into from

Conversation

Mossaka
Copy link
Contributor

@Mossaka Mossaka commented May 16, 2022

this PR adds the http webhook validation function to Spin SDK; The detailed specification for validation is written here.

This is the first PR to implement the Spin SIP #398 . See related discussion here #394

Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
sdk/rust/src/webhook.rs Outdated Show resolved Hide resolved
sdk/rust/src/webhook.rs Outdated Show resolved Hide resolved
@Mossaka Mossaka marked this pull request as ready for review May 18, 2022 19:53
@lann
Copy link
Collaborator

lann commented May 20, 2022

We have been discussing package organization and I think it would make sense for this to live in an outside repository. @michelleN suggests that a new deislabs/spin-cloudevents repo might be a good home for this code plus any future cloudevents trigger executor(s) (which should become much easier with #513!).

Edit: We'll also probably move the redis trigger into a fermyon/spin-redis repo.

@lann
Copy link
Collaborator

lann commented May 20, 2022

Oh! We were also discussing adding a "related projects" section to this repo's README, which would include a link to your repo.

@Mossaka
Copy link
Contributor Author

Mossaka commented May 22, 2022

@lann okay I will try #513 out on a new repo.

@lann
Copy link
Collaborator

lann commented May 23, 2022

Is this spec used anywhere apart from CloudEvents?

@Mossaka
Copy link
Contributor Author

Mossaka commented May 23, 2022

Is this spec used anywhere apart from CloudEvents?

so far I haven't seen it being used in other places.

@radu-matei
Copy link
Member

Thanks a lot for the contribution, @Mossaka!

It seems like it would make sense for this functionality to be part of a repo that was focused on adding CloudEvents support for Spin, rather than in the Spin repo itself.
As we were discussing in the developer meeting, that repo could evolve to include support for subscription managers and other things.

Then we can link the repo in the documentation and in the readme.
What do you think?

@Mossaka
Copy link
Contributor Author

Mossaka commented May 25, 2022

@radu-matei yep I will move to spin-cloudevents repo.

@Mossaka Mossaka closed this May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants