fix(auth): Parse URL from request parts to enable wasmtime serve
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
michelleN
approved these changes
Nov 2, 2023
| .ok_or(anyhow::anyhow!("missing host header"))?; | ||
| let host = String::from_utf8_lossy(header); | ||
| let path = request.path_with_query().unwrap_or_default(); | ||
| let full = format!("http://{}{}", host, path); |
There was a problem hiding this comment.
We might want to consider not hardcoding scheme in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin's HTTP crate formats a uri of a request, while
wasmtimedoes not, leaving it as solely being the path (/).This constructs the url from the request parts rather than relying on the spin crate, making it a more universal component that can now run with wasmtime with
wasmtime serve service.wasm --addr 127.0.0.1:3000Also, removes unused arguments