Skip to content

Deflake windows tests #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 15, 2021
Merged

Deflake windows tests #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d7099a4
Try deflaking the windows tests
fergusstrange Sep 15, 2021
cdca268
Sleep 1 second not 1 nano second!
fergusstrange Sep 15, 2021
49bf5d7
Wait up to 30 seconds
fergusstrange Sep 15, 2021
e3576f8
Reorder tests
fergusstrange Sep 15, 2021
f8821c0
Purge after each test
fergusstrange Sep 15, 2021
f9d2e7b
Stop using t.Run()
fergusstrange Sep 15, 2021
bba5d0e
Try ditching manual clean up
fergusstrange Sep 15, 2021
660fc0c
Try using os temp dir instead, allowing OS to clean up
fergusstrange Sep 15, 2021
dd4a45a
Ditch cleaning up filepath
fergusstrange Sep 15, 2021
4c0296e
Ditch cleaning up filepath
fergusstrange Sep 15, 2021
e8e7982
Stop running tests 100 times
fergusstrange Sep 15, 2021
68a1ef5
Purge extra unused log
fergusstrange Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,4 @@ jobs:
- name: Platform Tests
run: |
cd platform-test
go test -v ./...
go test -v -race ./...
16 changes: 8 additions & 8 deletions platform-test/platform_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ import (
"database/sql"
"fmt"
"io/ioutil"
"os"
"path/filepath"
"strconv"
"strings"
"testing"

Expand All @@ -21,15 +19,19 @@ func Test_AllMajorVersions(t *testing.T) {
embeddedpostgres.V10,
embeddedpostgres.V9,
}
tempExtractLocation, err := ioutil.TempDir("", "embedded_postgres_go_tests")

tempExtractLocation, err := ioutil.TempDir("", "embedded_postgres_tests")
if err != nil {
t.Fatal(err)
}

for testNumber, version := range allVersions {
for i, v := range allVersions {
testNumber := i
version := v
t.Run(fmt.Sprintf("MajorVersion_%s", version), func(t *testing.T) {
port := uint32(5555 + testNumber)
runtimePath := filepath.Join(tempExtractLocation, strconv.Itoa(testNumber))
runtimePath := filepath.Join(tempExtractLocation, string(version))

database := embeddedpostgres.NewDatabase(embeddedpostgres.DefaultConfig().
Version(version).
Port(port).
Expand Down Expand Up @@ -65,15 +67,13 @@ func Test_AllMajorVersions(t *testing.T) {
}
})
}
if err := os.RemoveAll(tempExtractLocation); err != nil {
t.Fatal(err)
}
}

func shutdownDBAndFail(t *testing.T, err error, db *embeddedpostgres.EmbeddedPostgres, version embeddedpostgres.PostgresVersion) {
if err := db.Stop(); err != nil {
t.Fatalf("Failed for version %s with error %s", version, err)
}

t.Fatalf("Failed for version %s with error %s", version, err)
}

Expand Down