Skip to content

Commit

Permalink
[css-flexbox-1] Add DoC and update Changes list.
Browse files Browse the repository at this point in the history
  • Loading branch information
@fantasai @fergald
fantasai authored and fergald committed May 7, 2018
1 parent 1ae5652 commit 0de3589
Show file tree
Hide file tree
Showing 3 changed files with 208 additions and 5 deletions.
19 changes: 14 additions & 5 deletions css-flexbox-1/Overview.bs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3455,6 +3455,8 @@ Boris Zbarsky.
<h3 id="changes-20171016">
Changes since the 16 October 2017 CR</h3>

A <a href="https://drafts.csswg.org/css-flexbox-1/issues-cr-2017">Disposition of Comments</a> is also available.

<ul>
<li id="change-2017-margin-padding-percent">
Removed the option for flex-item block-axis margins and paddings
Expand All @@ -3479,13 +3481,20 @@ Changes since the 16 October 2017 CR</h3>

<li id="change-2017-min-size-auto">
Moved the definition of the ''min-width/auto'' keyword for 'min-width' and 'min-height'
to [[!CSS-SIZING-3]],
and altered the computation of ''min-width/auto''
such that it always computes to itself
(although its <a>resolved value</a> remains zero on CSS2 display types).
to [[!CSS-SIZING-3]].
The definition of what an <a>automatic minimum size</a> for flex items is remains here.
(<a href="https://github.com/w3c/csswg-drafts/issues/2103">Issue 2103</a>,
(<a href="https://github.com/w3c/csswg-drafts/issues/1920">Issue 1920</a>,
<a href="https://github.com/w3c/csswg-drafts/issues/2103">Issue 2103</a>)

<li id="change-2017-min-size-auto-computation">
Altered the computation of ''min-width/auto'' in 'min-width' and 'min-height'
such that it always computes to itself--
although its <a>resolved value</a> remains zero on CSS2 display types.
(<a href="https://github.com/w3c/csswg-drafts/issues/2230">Issue 2230</a>,
<a href="https://github.com/w3c/csswg-drafts/issues/2248">Issue 2248</a>)

<li>
Some minor editorial fixes and clarifications.
</ul>

<h3 id="changes-20160526">
Expand Down
62 changes: 62 additions & 0 deletions css-flexbox-1/issues-cr-2017.bsi
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
Draft: https://www.w3.org/TR/2017/CR-css-flexbox-1-20171019/
Title: CSS Flexible Box Module Level 1

----
Issue 1.
Summary: Move min-width/min-height: auto definitions to css-sizing
From: Oriol Brufau
Comment: https://github.com/w3c/csswg-drafts/issues/1920
Response: https://github.com/w3c/csswg-drafts/issues/1920#issuecomment-342008468
Comment: https://github.com/w3c/csswg-drafts/issues/2103
Response: https://github.com/w3c/csswg-drafts/issues/2103#issuecomment-360955736
Closed: Accepted
Resolved: https://lists.w3.org/Archives/Public/www-style/2017Dec/0004.html
----
Issue 2.
Summary: Choose single option for resolving margin/padding percentages
From: Rossen Atanassov
Comment: https://github.com/w3c/csswg-drafts/issues/2085
Response: https://github.com/w3c/csswg-drafts/issues/2085#issuecomment-362000362
Changes: https://github.com/w3c/csswg-drafts/commit/db68ee43e752fabf68fd1e776a0ac840f4d3e971
Closed: Accepted
Resolved: https://lists.w3.org/Archives/Public/www-style/2018Feb/0000.html
----
Issue 3.
Summary: When does min-width/min-height: auto compute to auto vs zero?
From: fantasai
Comment: https://github.com/w3c/csswg-drafts/issues/2230
Changes: https://github.com/w3c/csswg-drafts/commit/cf709be33562b27fddd4200824d876378f47fe6d
Closed: Accepted
Resolved: https://lists.w3.org/Archives/Public/www-style/2018Feb/0000.html
----
Issue 4.
Summary: Make min-width: auto compute to auto always, resolve to zero as needed
From: Daniel Holbert
Comment: https://github.com/w3c/csswg-drafts/issues/2248#issuecomment-362114572
Closed: Accepted
Resolved: https://github.com/w3c/csswg-drafts/issues/2248#issuecomment-365688138
Verified: https://github.com/w3c/csswg-drafts/issues/2248#issuecomment-370625542
----
Issue 5.
Summary: Min-content sizing too smart to be web compatible
From: François Remy
Comment: https://github.com/w3c/csswg-drafts/issues/2353
Open
----
Issue 6.
Summary: Make order do semantic reordering
From: Robert Utasi
Comment: https://github.com/w3c/csswg-drafts/issues/2405
Response: https://github.com/w3c/csswg-drafts/issues/2405#issuecomment-371528202
???: https://github.com/w3c/csswg-drafts/issues/2405#issuecomment-371590054
Closed: Rejected
Resolved: previous CSSWG resolutions, Web platform architectural principles, etc.
----
Issue 7.
Summary: Use more formal language in note
From: Nadya678
Comment: https://github.com/w3c/csswg-drafts/issues/2431
Response: https://github.com/w3c/csswg-drafts/issues/2431#issuecomment-372120318
Closed: Accepted
Changes: (note was removed entirely due to issue 2)
----
132 changes: 132 additions & 0 deletions css-flexbox-1/issues-cr-2017.html
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,132 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>CSS Flexible Box Module Level 1 Disposition of Comments for 2017-10-19 CR</title>
<style type="text/css">
pre { border: solid thin silver; padding: 0.2em; white-space: normal; }
pre > span { display: block; white-space: pre; }
.a { background: #52E052 }
.d { background: #8CCBF2 }
.oi { background: #E0CB52 }
.r { background: orange }
.fo { background: #f66 }
pre.a { background: #E9FBE9 }
pre.d { background: #DEF }
pre.oi { background: #FCFAEE }
pre.r { background: #FFEECC }
pre.fo { background: #FBE9E9 }
.open { border: solid red; }
:target { box-shadow: 0.25em 0.25em 0.25em; }
a[href^=mid], a[href~=flatten] { text-decoration: none; }
abbr { font-weight: bold; }
</style>

<h1>CSS Flexible Box Module Level 1 Disposition of Comments for 2017-10-19 CR</h1>

<p>Dated Draft: <a href="https://www.w3.org/TR/2017/CR-css-flexbox-1-20171019/">https://www.w3.org/TR/2017/CR-css-flexbox-1-20171019/</a>

<p>Editor's Draft: <a href="http://drafts.csswg.org/css-flexbox-1/">http://drafts.csswg.org/css-flexbox-1/</a>

<p>The following color coding convention is used for comments:</p>

<ul>
<li class="a">Accepted or Rejected and positive response
<li class="r">Rejected and no response
<li class="fo">Rejected and negative response
<li class="d">Deferred
<li class="oi">Out-of-Scope or Invalid and not verified
</ul>

<p class=open>Open issues are marked like this</p>

<p>An issue can be closed as <code>Accepted</code>, <code>OutOfScope</code>,
<code>Invalid</code>, <code>Rejected</code>, or <code>Retracted</code>.
<code>Verified</code> indicates commentor's acceptance of the response.</p>
<pre class=' a' id='issue-1'>
<span>Issue 1. <a href='#issue-1'>#</a></span>
<span>Summary: Move min-width/min-height: auto definitions to css-sizing</span>
<span>From: Oriol Brufau</span>
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/1920'>https://github.com/w3c/csswg-drafts/issues/1920</a></span>
<span>Response: <a href='https://github.com/w3c/csswg-drafts/issues/1920#issuecomment-342008468'>https://github.com/w3c/csswg-drafts/issues/1920#issuecomment-342008468</a></span>
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/2103'>https://github.com/w3c/csswg-drafts/issues/2103</a></span>
<span>Response: <a href='https://github.com/w3c/csswg-drafts/issues/2103#issuecomment-360955736'>https://github.com/w3c/csswg-drafts/issues/2103#issuecomment-360955736</a></span>
<span class="a">Closed: Accepted</span>
<span>Resolved: <a href='https://lists.w3.org/Archives/Public/www-style/2017Dec/0004.html'>https://lists.w3.org/Archives/Public/www-style/2017Dec/0004.html</a> <a href="https://www.w3.org/Mail/flatten/index?subject=https%3A%2F%2Flists.w3.org%2FArchives%2FPublic%2Fwww-style/2017Dec/0004.html"><abbr title="Thread">&#x2208;</abbr></a></span></pre>
<pre class=' a' id='issue-2'>
<span>Issue 2. <a href='#issue-2'>#</a></span>
<span>Summary: Choose single option for resolving margin/padding percentages</span>
<span>From: Rossen Atanassov</span>
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/2085'>https://github.com/w3c/csswg-drafts/issues/2085</a></span>
<span>Response: <a href='https://github.com/w3c/csswg-drafts/issues/2085#issuecomment-362000362'>https://github.com/w3c/csswg-drafts/issues/2085#issuecomment-362000362</a></span>
<span>Changes: <a href='https://github.com/w3c/csswg-drafts/commit/db68ee43e752fabf68fd1e776a0ac840f4d3e971'>https://github.com/w3c/csswg-drafts/commit/db68ee43e752fabf68fd1e776a0ac840f4d3e971</a></span>
<span class="a">Closed: Accepted</span>
<span>Resolved: <a href='https://lists.w3.org/Archives/Public/www-style/2018Feb/0000.html'>https://lists.w3.org/Archives/Public/www-style/2018Feb/0000.html</a> <a href="https://www.w3.org/Mail/flatten/index?subject=https%3A%2F%2Flists.w3.org%2FArchives%2FPublic%2Fwww-style/2018Feb/0000.html"><abbr title="Thread">&#x2208;</abbr></a></span></pre>
<pre class=' a' id='issue-3'>
<span>Issue 3. <a href='#issue-3'>#</a></span>
<span>Summary: When does min-width/min-height: auto compute to auto vs zero?</span>
<span>From: fantasai</span>
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/2230'>https://github.com/w3c/csswg-drafts/issues/2230</a></span>
<span>Changes: <a href='https://github.com/w3c/csswg-drafts/commit/cf709be33562b27fddd4200824d876378f47fe6d'>https://github.com/w3c/csswg-drafts/commit/cf709be33562b27fddd4200824d876378f47fe6d</a></span>
<span class="a">Closed: Accepted</span>
<span>Resolved: <a href='https://lists.w3.org/Archives/Public/www-style/2018Feb/0000.html'>https://lists.w3.org/Archives/Public/www-style/2018Feb/0000.html</a> <a href="https://www.w3.org/Mail/flatten/index?subject=https%3A%2F%2Flists.w3.org%2FArchives%2FPublic%2Fwww-style/2018Feb/0000.html"><abbr title="Thread">&#x2208;</abbr></a></span></pre>
<pre class=' a' id='issue-4'>
<span>Issue 4. <a href='#issue-4'>#</a></span>
<span>Summary: Make min-width: auto compute to auto always, resolve to zero as needed</span>
<span>From: Daniel Holbert</span>
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/2248#issuecomment-362114572'>https://github.com/w3c/csswg-drafts/issues/2248#issuecomment-362114572</a></span>
<span class="a">Closed: Accepted</span>
<span>Resolved: <a href='https://github.com/w3c/csswg-drafts/issues/2248#issuecomment-365688138'>https://github.com/w3c/csswg-drafts/issues/2248#issuecomment-365688138</a></span>
<span class="a">Verified: <a href='https://github.com/w3c/csswg-drafts/issues/2248#issuecomment-370625542'>https://github.com/w3c/csswg-drafts/issues/2248#issuecomment-370625542</a></span></pre>
<pre class='open ' id='issue-5'>
<span>Issue 5. <a href='#issue-5'>#</a></span>
<span>Summary: Min-content sizing too smart to be web compatible</span>
<span>From: François Remy</span>
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/2353'>https://github.com/w3c/csswg-drafts/issues/2353</a></span>
<span>Open</span></pre>
<pre class=' r' id='issue-6'>
<span>Issue 6. <a href='#issue-6'>#</a></span>
<span>Summary: Make order do semantic reordering</span>
<span>From: Robert Utasi</span>
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/2405'>https://github.com/w3c/csswg-drafts/issues/2405</a></span>
<span>Response: <a href='https://github.com/w3c/csswg-drafts/issues/2405#issuecomment-371528202'>https://github.com/w3c/csswg-drafts/issues/2405#issuecomment-371528202</a></span>
<span>???: <a href='https://github.com/w3c/csswg-drafts/issues/2405#issuecomment-371590054'>https://github.com/w3c/csswg-drafts/issues/2405#issuecomment-371590054</a></span>
<span class="r">Closed: Rejected</span>
<span>Resolved: previous CSSWG resolutions, Web platform architectural principles, etc.</span></pre>
<pre class=' a' id='issue-7'>
<span>Issue 7. <a href='#issue-7'>#</a></span>
<span>Summary: Use more formal language in note</span>
<span>From: Nadya678</span>
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/2431'>https://github.com/w3c/csswg-drafts/issues/2431</a></span>
<span>Response: <a href='https://github.com/w3c/csswg-drafts/issues/2431#issuecomment-372120318'>https://github.com/w3c/csswg-drafts/issues/2431#issuecomment-372120318</a></span>
<span class="a">Closed: Accepted</span>
<span>Changes: (note was removed entirely due to issue 2)</span></pre>
<script>
(function () {
var sheet = document.styleSheets[0];
function addCheckbox(className) {
var element = document.querySelector('*.' + className);
var span = document.createElement('span');
span.innerHTML = element.innerHTML;
element.innerHTML = null;
var check = document.createElement('input');
check.type = 'checkbox';
if (className == 'open') {
check.checked = false;
sheet.insertRule('pre:not(.open)' + '{}', sheet.cssRules.length);
check.onchange = function (e) {
rule.style.display = this.checked ? 'none' : 'block';
}
}
else {
check.checked = true;
sheet.insertRule('pre.' + className + '{}', sheet.cssRules.length);
check.onchange = function (e) {
rule.style.display = this.checked ? 'block' : 'none';
}
}
var rule = sheet.cssRules[sheet.cssRules.length - 1];
element.appendChild(check);
element.appendChild(span);
}
['a', 'd', 'fo', 'oi', 'r', 'open'].forEach(addCheckbox);
}());
</script>

0 comments on commit 0de3589

Please sign in to comment.