-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
very temp 429 fix #503
very temp 429 fix #503
Conversation
very simple and temp fix for latest update that causes big boi 429
can others comment on this? does this solve the 429 status error for you? |
Did not fix it for me |
Didn't fix for me too |
for me it fixed getting 429 from getting audio data |
Co-Authored-By: fent <fentbox@gmail.com>
Currently testing this as a fix for iv-org/invidious#811 (iv-org/invidious@dad885c). Additionally added:
Will report back with results. |
@Roki100 nope, i didnt get rate limited |
@RocoGreen then it works |
I just tried executing the BasicInfo function on a server (that is 429 blocked). With all 3 Options (normal ytdl-core, using this pull request, using this pull request + @omarroth user agent) In all 3 cases no output was generated and no error was logged (which I find strange) however the same script gives me a perfectly good output on my local machine and a new server, so I dont think its the script. If anyone wants me to test something on that server that is blocked, let me know Edit: the script: https://hastebin.com/qezanixiwa.js |
@userlip this isnt 429 removal pr(you cant remove existing 429), it should prevent getting more 429 in the future |
After testing the fix for a couple days I have not encountered the issue again. I've been testing on about 15 droplets from DigitalOcean with each droplet handling about 25 req/s. |
@omarroth Were those droplets rate limited in the past? Are they fresh? |
Looks like I spoke a bit too soon. Quite literally 10 minutes after posting all nodes have been banned. @WaqasIbrahim They are fresh. |
@omarroth are you using other features than downloading like info etc.? |
Yes, in addition to video metadata there are also requests for comments, search, channels, playlists, etc. All are made currently with the above headers. |
this would need use of &pbj=1 which would require rewrite of big part of ytdl |
fixed it for a second and then it broke again, you're getting close |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
very simple and temp fix for latest update that causes big boi 429, code can be edited
im also not sure if i did it right(implemented)/if it is working but i dont get 429 after adding this for now