Repository navigation
Conversation
conhost has VT processing off, so escape sequences from the greeting and diagnostics printed as garbage. Enable it on stdout and stderr at startup. toiletline's raw mode turns off newline auto-return, so a bare \n only moves the cursor down, and `write_fd` sends bare \n, which left the cursor in the middle of the line. Emit \r\n for console handles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toiletline's raw mode turns off newline auto-return, so a bare
\nonly movesthe cursor down, and
write_fdsends bare\n, which left the cursor in themiddle of the line. Emit
\r\nfor console handles.Also conhost has VT processing off, so escape sequences were printed as garbage.
Enable it on stdout and stderr at startup.