Harden core reliability: shortcut persistence, hotkey registration, browser switching, and instant switching

[fenilsonani]

Summary

The app is in good shape structurally, but the main user-facing flows still have a few reliability problems that make MenuBrowser feel fragile in real use.

Problems to fix

• Shortcut persistence treats key code 0 as "unset", which makes A-based shortcuts impossible to restore after relaunch.
• Global hotkey registration ignores Carbon return statuses, so conflicts and registration failures fail silently.
• Default browser switching updates http and https independently with no combined success handling or user-facing error state.
• Instant switching depends on a brittle AppleScript path (CoreServicesUIAgent + English Use button) and the launch-time accessibility prompt helper is not wired in.
• There are currently no automated tests covering these flows.

Expected outcome

• Shortcut persistence restores all valid shortcuts, including A.
• Hotkey registration reports failure and the UI reflects that state.
• Browser switching reports success/failure clearly and avoids leaving the app looking successful when it was only partially successful.
• Instant switching is safer, less brittle, and communicates limitations/failure clearly.
• Add regression coverage for stateful behavior where practical.

Notes

This issue is intended to track the immediate hardening pass for the current MVP, not a broad redesign.

[fenilsonani]

Started the hardening pass and implemented the first reliability batch locally:\n\n- fixed shortcut persistence so keycode 0 () restores correctly\n- surfaced hotkey registration failures in the app UI/menu\n- added combined error handling and rollback logic for browser switching\n- made instant-switching messaging more honest and the auto-confirm path less brittle\n- added a lightweight automated regression runner and wired it into CI\n\nLocal verification completed with PASS: restores A shortcut from defaults
PASS: falls back to default shortcut when no preference exists
PASS: browser ordering preserves saved order and appends new browsers
PASS: hotkey conflict returns a friendly message
PASS: hotkey success returns no error
All tests passed: 5 and Cleaning build directory...
Compiling...
Copying Info.plist...
Copying app icon...
Code signing...
Signed with: MenuBrowser Development
Build complete: build/MenuBrowser.app
Run with: open build/MenuBrowser.app.

[fenilsonani]

Started the hardening pass and implemented the first reliability batch locally:

• fixed shortcut persistence so keycode 0 (A) restores correctly
• surfaced hotkey registration failures in the app UI/menu
• added combined error handling and rollback logic for browser switching
• made instant-switching messaging more honest and the auto-confirm path less brittle
• added a lightweight automated regression runner and wired it into CI

Local verification completed with ./test.sh and ./build.sh.