Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Mode 2 not working as expected in v1.3.0 #304

Closed
1 task done
supachailllpay opened this issue Feb 26, 2018 · 4 comments
Closed
1 task done

View Mode 2 not working as expected in v1.3.0 #304

supachailllpay opened this issue Feb 26, 2018 · 4 comments
Labels

Comments

@supachailllpay
Copy link

supachailllpay commented Feb 26, 2018

In v1.3.0 I found the behavior of setting viewMode to 2 is changed (previous version example).

I think this behavior does not follow the explanation as in document:

Restrict the minimum canvas size to fit within the container. If the proportions of the the canvas and the container differ, the minimum canvas will be surrounded by extra space in one of the dimensions.

Browser:

  • Chrome (desktop) version 64

Thank you

@fengyuanchen
Copy link
Owner

The view mode 2 is designed as this. If you cannot understand the explanation , any more clearer explanations are welcome.

@supachailllpay
Copy link
Author

So In the demo site what is difference between VM2 and VM3?

2: Restrict the minimum canvas size to fit within the container. If the proportions of the the canvas and the container differ, the minimum canvas will be surrounded by extra space in one of the dimensions.

3: Restrict the minimum canvas size to fill fit the container. If the proportions of the canvas and the container are different, the container will not be able to fit the whole canvas in one of the dimensions.

In VM2, Should it have some extra space as previous version had (v1.2.2)?

Thank you

@fengyuanchen
Copy link
Owner

In the official demo, you can not find the difference between 2 and 3 because of the image container aspect ratio is just similar as the image's.

You can change view mode from 2 to 3 in your provided example, and you will see the difference.

@supachailllpay
Copy link
Author

Yes in my example (v1.2.2) is in view mode 2 and you can see extra space right?. but it's not in v1.3.0 see here. Is it should be in this way?

Thank you

@fengyuanchen fengyuanchen reopened this Feb 27, 2018
fengyuanchen added a commit that referenced this issue Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants