Skip to content

chore(deps): bump vite-plus to pkg-pr-new pr-1588 - #19

Draft
fengmk2 wants to merge 1 commit into
minorfrom
update-vite-plus-prerelease-test-pr-1588
Draft

chore(deps): bump vite-plus to pkg-pr-new pr-1588#19
fengmk2 wants to merge 1 commit into
minorfrom
update-vite-plus-prerelease-test-pr-1588

Conversation

@fengmk2

@fengmk2 fengmk2 commented May 28, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus to pkg-pr-new build for PR #1588 (replace @voidzero-dev/vite-plus-test wrapper with upstream vitest@4.1.5).

Updated where applicable:

  • `vite-plus` → `https://pkg.pr.new/voidzero-dev/vite-plus@1588\`
  • `vite` alias → pkg-pr-new core URL
  • `vitest` alias → `^4.1.5` (no longer wrapped; was `@voidzero-dev/vite-plus-test`)
  • overrides → SHA-pinned (`5577b01`)
  • min-release-age config updated

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependencies in package.json and pnpm-workspace.yaml, switching to specific PR-based builds for vite-plus and vite, and adjusting workspace configurations such as minimumReleaseAge and overrides. The review feedback recommends aligning the vitest version with other related packages to prevent mismatches, and pinning the PR-based dependencies to a specific commit SHA instead of mutable PR numbers to ensure build reproducibility.

Comment thread package.json
"vite": "catalog:",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest",
"vite-plus": "^0.1.22"
"vitest": "^4.1.5",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To prevent potential version mismatch issues and ensure compatibility, vitest should be aligned with the other Vitest packages in devDependencies (such as @vitest/coverage-v8 and @vitest/ui), which are currently set to ^4.1.7.

Suggested change
"vitest": "^4.1.5",
"vitest": "^4.1.7",

Comment thread package.json
"vitest": "npm:@voidzero-dev/vite-plus-test@latest",
"vite-plus": "^0.1.22"
"vitest": "^4.1.5",
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1588"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To ensure build reproducibility and prevent version mismatch issues, it is recommended to pin vite-plus to the same commit SHA (5577b0154f33d1480a3c96347e94fa5d2094de2e) used in the overrides section of pnpm-workspace.yaml. Using the mutable PR number @1588 can lead to out-of-sync dependencies if new commits are pushed to the PR.

Suggested change
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1588"
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@5577b0154f33d1480a3c96347e94fa5d2094de2e"

Comment thread pnpm-workspace.yaml
'entities': '^7.0.1'
'estree-walker': ^2.0.2
'vite': npm:@voidzero-dev/vite-plus-core@latest
'vite': 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1588'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similarly, the vite catalog entry should be pinned to the specific commit SHA (5577b0154f33d1480a3c96347e94fa5d2094de2e) instead of the mutable PR number @1588 to maintain consistency with the overrides and ensure reproducible builds.

  'vite': 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@5577b0154f33d1480a3c96347e94fa5d2094de2e'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant