chore(deps): bump vite-plus to pkg-pr-new pr-1588 - #19
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates dependencies in package.json and pnpm-workspace.yaml, switching to specific PR-based builds for vite-plus and vite, and adjusting workspace configurations such as minimumReleaseAge and overrides. The review feedback recommends aligning the vitest version with other related packages to prevent mismatches, and pinning the PR-based dependencies to a specific commit SHA instead of mutable PR numbers to ensure build reproducibility.
| "vite": "catalog:", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@latest", | ||
| "vite-plus": "^0.1.22" | ||
| "vitest": "^4.1.5", |
There was a problem hiding this comment.
| "vitest": "npm:@voidzero-dev/vite-plus-test@latest", | ||
| "vite-plus": "^0.1.22" | ||
| "vitest": "^4.1.5", | ||
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1588" |
There was a problem hiding this comment.
To ensure build reproducibility and prevent version mismatch issues, it is recommended to pin vite-plus to the same commit SHA (5577b0154f33d1480a3c96347e94fa5d2094de2e) used in the overrides section of pnpm-workspace.yaml. Using the mutable PR number @1588 can lead to out-of-sync dependencies if new commits are pushed to the PR.
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1588" | |
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@5577b0154f33d1480a3c96347e94fa5d2094de2e" |
| 'entities': '^7.0.1' | ||
| 'estree-walker': ^2.0.2 | ||
| 'vite': npm:@voidzero-dev/vite-plus-core@latest | ||
| 'vite': 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1588' |
There was a problem hiding this comment.
Similarly, the vite catalog entry should be pinned to the specific commit SHA (5577b0154f33d1480a3c96347e94fa5d2094de2e) instead of the mutable PR number @1588 to maintain consistency with the overrides and ensure reproducible builds.
'vite': 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@5577b0154f33d1480a3c96347e94fa5d2094de2e'
Summary
Bump vite-plus to pkg-pr-new build for PR #1588 (replace @voidzero-dev/vite-plus-test wrapper with upstream vitest@4.1.5).
Updated where applicable:
Test plan