chore(deps): bump vite-plus to 0.1.21-alpha.7 - #17
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the versions of vitest, vite-plus, and vite to specific alpha releases and adds a minimumReleaseAgeExclude section to the workspace configuration. The reviewer suggests centralizing dependency management by adding vitest and vite-plus to the workspace catalog and using the catalog: protocol in package.json. There is also a concern regarding the placement of the minimumReleaseAgeExclude field, which may not be a standard pnpm-workspace.yaml property, along with a suggestion to use single quotes for consistency.
| 'entities': '^7.0.1' | ||
| 'estree-walker': ^2.0.2 | ||
| 'vite': npm:@voidzero-dev/vite-plus-core@latest | ||
| 'vite': npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.7 |
There was a problem hiding this comment.
To improve maintainability and ensure version consistency across the workspace, consider adding vitest and vite-plus to the catalog. This centralizes version management for the entire vite-plus suite, following the pattern already established for vite.
'vite': npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.7
'vitest': npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7
'vite-plus': 0.1.21-alpha.7| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7", | ||
| "vite-plus": "0.1.21-alpha.7" |
There was a problem hiding this comment.
Since vite is already using the workspace catalog, it is recommended to do the same for vitest and vite-plus (after adding them to the catalog in pnpm-workspace.yaml). This keeps the root package.json clean and ensures all packages in the workspace use the same versions.
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7", | |
| "vite-plus": "0.1.21-alpha.7" | |
| "vitest": "catalog:", | |
| "vite-plus": "catalog:" |
| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - "@voidzero-dev/*" |
There was a problem hiding this comment.
Regarding the minimumReleaseAgeExclude configuration:
- Configuration Location: This is not a standard top-level field for
pnpm-workspace.yamlinpnpmorbun. Forpnpm, this setting typically belongs in.npmrcasminimum-release-age-exclude. If this is intended for a custom tool, please verify the location; otherwise, it might be ignored by the package managers. - Style Consistency: Use single quotes for
'@voidzero-dev/*'to match the established style in the rest of the file (e.g., lines 6, 7, 11).
minimumReleaseAgeExclude:
- vite-plus
- '@voidzero-dev/*'
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.7.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsminimumReleaseAgeExclude/minimumReleaseAgeExcludesconfigured for pnpm + bunTest plan