chore(deps): bump vite-plus to v0.1.24 - #7
Draft
fengmk2 wants to merge 3 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the vite-plus dependency to a preview build and configures a minimum release age in .npmrc. The review feedback correctly identifies that the .npmrc configuration uses the incorrect option min-release-age-exclude instead of min-release-age-exceptions, which would cause the exclusion list to be ignored.
| @@ -0,0 +1,2 @@ | |||
| min-release-age=3600 | |||
| min-release-age-exclude=vite-plus,vite,vitest,@voidzero-dev/*,@oxc-project/*,@oxlint/*,oxlint,oxfmt,oxlint-tsgolint | |||
There was a problem hiding this comment.
In pnpm, the configuration option to exclude packages from the minimum release age check is min-release-age-exceptions, not min-release-age-exclude. Using min-release-age-exclude will cause the exclusion list to be ignored, which will block the installation of newly built packages (like the pkg.pr.new build of vite-plus).
min-release-age-exceptions=vite-plus,vite,vitest,@voidzero-dev/*,@oxc-project/*,@oxlint/*,oxlint,oxfmt,oxlint-tsgolint
fengmk2
changed the title
…ys and over-blocked install)
…elease-age (4.1.8 is <1d old)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
vite-plusand related packages to the pkg.pr.new prerelease build for v0.1.24.Updated where applicable:
vite-plus-> pkg.pr.newvite/vitestaliases and overrides ->@voidzero-dev/vite-plus-core/@voidzero-dev/vite-plus-test@voidzero-dev/vite-plus-*direct deps,overrides/resolutions/pnpm.overrides/ catalogsminimum-release-agewith vite-plus stack excluded (pnpm / npm / bun / yarn as applicable)pnpm.*package.json fields intopnpm-workspace.yamlwhere presentTest plan