renamed OpenSearchEmbeddingStore ITs according to conventions

feng1988 · Jan 25, 2024 · 3ac3ab8 · 3ac3ab8
1 parent 1214fe0
commit 3ac3ab8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/...arch/OpenSearchEmbeddingStoreAWSTest.java → ...search/OpenSearchEmbeddingStoreAwsIT.java b/...arch/OpenSearchEmbeddingStoreAWSTest.java → ...search/OpenSearchEmbeddingStoreAwsIT.java
@@ -27,7 +27,7 @@
 import static org.awaitility.Awaitility.await;
 
 @Testcontainers
-public class OpenSearchEmbeddingStoreAWSTest extends EmbeddingStoreIT {
+class OpenSearchEmbeddingStoreAwsIT extends EmbeddingStoreIT {
 
     @Container
     private static final LocalStackContainer localstack = new LocalStackContainer(DockerImageName.parse("localstack/localstack:latest"));
@@ -53,11 +53,11 @@ static void beforeAll() throws IOException, InterruptedException {
         await().pollInterval(Duration.ofSeconds(30))
                 .atMost(Duration.ofSeconds(300))
                 .untilAsserted(() -> {
-            ExecResult execResult = localstack.execInContainer(describeDomainCmd);
-            String response = execResult.getStdout();
-            JSONArray processed = JsonPath.read(response, "$.DomainStatus[?(@.Processing == false)]");
-            assertThat(processed).isNotEmpty();
-        });
+                    ExecResult execResult = localstack.execInContainer(describeDomainCmd);
+                    String response = execResult.getStdout();
+                    JSONArray processed = JsonPath.read(response, "$.DomainStatus[?(@.Processing == false)]");
+                    assertThat(processed).isNotEmpty();
+                });
     }
 
     @Override

diff --git a/...ch/OpenSearchEmbeddingStoreLocalTest.java → ...arch/OpenSearchEmbeddingStoreLocalIT.java b/...ch/OpenSearchEmbeddingStoreLocalTest.java → ...arch/OpenSearchEmbeddingStoreLocalIT.java
@@ -7,15 +7,13 @@
 import dev.langchain4j.store.embedding.EmbeddingStoreIT;
 import lombok.SneakyThrows;
 import org.junit.jupiter.api.BeforeAll;
-import org.junit.jupiter.api.Disabled;
 import org.opensearch.testcontainers.OpensearchContainer;
 import org.testcontainers.junit.jupiter.Container;
 import org.testcontainers.utility.DockerImageName;
 
 import static dev.langchain4j.internal.Utils.randomUUID;
 
-@Disabled("Needs OpenSearch running locally")
-class OpenSearchEmbeddingStoreLocalTest extends EmbeddingStoreIT {
+class OpenSearchEmbeddingStoreLocalIT extends EmbeddingStoreIT {
 
     /**
      * To run the tests locally, you don't need to have OpenSearch up-and-running. This implementation