Skip to content

ID-4028 fikse docker image#66

Merged
oyri merged 11 commits into
mainfrom
ID-4028
Mar 6, 2024
Merged

ID-4028 fikse docker image#66
oyri merged 11 commits into
mainfrom
ID-4028

Conversation

@lineshr
Copy link
Copy Markdown
Contributor

@lineshr lineshr commented Mar 6, 2024

No description provided.

exit-code: "1"
severity: "CRITICAL,HIGH"
- name: "Login to Azure Container registery"
- name: 'Login to Azure Container registery and Build the tagged Docker image'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skulle du eigentleg lagt til beskrivelsen på step-et under? denne er korrekt slik den var, er berre login.

login-server: ${{ secrets.REGISTRY_URL }}
username: ${{ secrets.REGISTRY_USERNAME }}
password: ${{ secrets.REGISTRY_PASSWORD }}
- run: |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kan legge på name med beskrivelse her om du vil (saman med run)

docker push ${{env.IMAGE-NAME}}:${{env.IMAGETAG}}
docker image tag ${{env.IMAGE-NAME}}:latest && docker push ${{env.IMAGE-NAME}}:latest
- run: echo "IMAGE_DIGEST=$(docker inspect --format='{{.RepoDigests}}' ${{env.IMAGE-NAME}}:${{env.IMAGETAG}}|cut -d '@' -f 2|cut -d ']' -f 1)" >> "$GITHUB_ENV"
docker push ${{ secrets.REGISTRY_URL }}/${{env.IMAGE_NAME}}:${{env.IMAGETAG}}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registery-url er alt lagt inn i image-name, så ikkje endre namnet på docker image her eller på linja under. Berre endre på ekstra parameter på linja under.

login-server: ${{ secrets.REGISTRY_URL }}
username: ${{ secrets.REGISTRY_USERNAME }}
password: ${{ secrets.REGISTRY_PASSWORD }}
- name: 'Build the tagged Docker image'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

må ha berre 1 bindestrek - elles blir det nytt step. sjå https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idsteps. Du må sjekke syntax før du legg inn endringar!

@lineshr lineshr requested a review from oyri March 6, 2024 11:33
- name: "Build the tagged Docker image"
run: |
docker push ${{ secrets.REGISTRY_URL }}:${{env.IMAGETAG}}
docker image tag ${{ secrets.REGISTRY_URL }}:${{env.IMAGETAG}} ${{ secrets.REGISTRY_URL }}:latest && docker push ${{ secrets.REGISTRY_URL }}:latest
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

du må ikkje endre den eksisterande koden som var korrekt. berre legge til param nr 2 som mangla på kommandoen docker image tag

@lineshr lineshr requested a review from oyri March 6, 2024 12:50
@oyri oyri merged commit d39934d into main Mar 6, 2024
@oyri oyri deleted the ID-4028 branch March 6, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants