Skip to content

PF-2383 Upgrade to Node 24 (with lint setup fixes)#102

Merged
jasaltvik merged 19 commits into
mainfrom
EUW-1427-2
May 12, 2026
Merged

PF-2383 Upgrade to Node 24 (with lint setup fixes)#102
jasaltvik merged 19 commits into
mainfrom
EUW-1427-2

Conversation

@andreasbalevik
Copy link
Copy Markdown
Collaborator

@andreasbalevik andreasbalevik commented Apr 24, 2026

This ensures the repo is compatible with the upcoming deprecation of Node 20 in GitHub Actions runners: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/.

This contains more changes than just Node 24 upgrades, but we've decided to fix it all as part of upgrading Node so that we only have to create a single release.


Node 24 changes

  • package.json is updated to require Node 24 where applicable
  • action.yml is updated to use Node 24 where applicable
  • Actions pulled in via composite steps are upgraded to Node 24-compatible versions
    • This required quite big changes for certain actions like in the Slack action

Lint

  • Consolidate linting to fix the discrepancies between local testing and pipeline testing (this means dropping super-linter and using npm run lint in pipeline as well)
  • Add pre-commit hook to lint changed files (workflow checks all files)
  • Upgraded actions in all lint/test workflows

Other changes

  • The Slack action needed quite a lot of changes to work with the new versions, so we snuck in some QoL updates
    • Color support
    • Avoid adding links to Jira for empty jira-id, or if jira-id is Dependabot
    • Avoid adding links to PR, if pr-number is empty
  • Most actions had invalid input configuration as type is not allowed for composite actions. These are removed
  • Added description for all inputs as this is best practice
  • Upgraded actions

Testing


After merge

  • Create new release
  • Update all use of actions from this repo to the new version

@jasaltvik jasaltvik changed the title Oppgradere til Node 24 og forenkle lint setup PF-2383 Oppgradere til Node 24 og forenkle lint setup May 8, 2026
@jasaltvik jasaltvik changed the title PF-2383 Oppgradere til Node 24 og forenkle lint setup PF-2383 Upgrade to Node 24 (also includes lint setup fixes) May 11, 2026
@jasaltvik jasaltvik requested a review from a team May 11, 2026 10:36
@jasaltvik jasaltvik changed the title PF-2383 Upgrade to Node 24 (also includes lint setup fixes) PF-2383 Upgrade to Node 24 (with lint setup fixes) May 12, 2026
@jasaltvik jasaltvik merged commit d7888fe into main May 12, 2026
14 checks passed
@jasaltvik jasaltvik deleted the EUW-1427-2 branch May 12, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants