pkg/encoding: reduce allocations - #1
Open
narqo wants to merge 2 commits into
Open
Conversation
narqo
force-pushed
the
decoder-allocs
branch
2 times, most recently
from
January 10, 2023 08:44
1d77c90 to
8c2a15f
Compare
Owner
|
Hey, thanks for this, I'll take a look when I get a chance. Right now the benchmark is biased towards processing lots of small traces, but for the implementation I probably want to bias towards efficiently processing large traces. I probably need to reflect the benchmark a bit to reflect that. If I'm reading your code correctly, this would mostly help for processing lots of small traces, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fairly quick and dirty change, that reduces some obvious allocations :)
(updated the results after running the benchmarks on m1 mac)