fix(DefinitionResolver): find variables in sibling children

[felixfbecker]

Fixes #566

[codecov]

Codecov Report

Merging #568 into master will increase coverage by 0.05%.
The diff coverage is 94.44%.

@@             Coverage Diff              @@
##             master     #568      +/-   ##
============================================
+ Coverage     81.52%   81.57%   +0.05%     
- Complexity      901      906       +5     
============================================
  Files            61       61              
  Lines          2062     2068       +6     
============================================
+ Hits           1681     1687       +6     
  Misses          381      381

Impacted Files	Coverage Δ	Complexity Δ
src/DefinitionResolver.php	87.17% <94.44%> (+0.13%)	326 <11> (+5)	⬆️

[phil-nelson]

Thanks, this is a better solution that mine, I was struggling to work out how to do something like this as your suggestion.

[felixfbecker]

This also includes a change unrelated to the bug, in that before we only checked previous siblings and parents, but not the descendants of those. So this wouldn't register $foo before:

if (true) {
  $foo = 123
}
$f| // no completion for $foo

now it should.

With that change I could make it so that the search for the foreach key/value starts at the parent/sibling too because it can then traverse into the ForeachStatement, but not if that was the starting point.

[felixfbecker]

@jens1o @phil-nelson if anyone wants to test: php-intellisense-1.5.4.vsix.zip

[phil-nelson]

I've had a play with this branch, no problems so far 👍

[jens1o]

Works like a charm :)