memory leak

[jens1o]

Project: http://github.com/jens1o/hitbox-api-php (I'd granted you access)
(you need to execute composer install)
Log: https://hastebin.com/esaximiped.tex

Can I help you with something else? I just coded normal(the things from the last php commit) and finally, it freezed.

[felixfbecker]

Are you sure it's a leak and not just the limit too low?
No idea what could leak here tbh

[jens1o]

I don't know either. I'm pretty sure it's a leak, because it's just less than 100 files. Also, I saw in the task manager I'd openend(because that happened earlier this day too, this is the second time) and I saw how it rose. In the panic I'd forgot to look after a screenshot. The parsing of the files was more than a hour ago... I don't expect reparsing anything. At the start, it were 64 MiB. I don't know why it allocates more than four gigabytes... But I saw that it's the "CLI" process, so I also think that this language server is the cause.

[jens1o]

I can reproduce it! (I'd maked a detailed look at the RAM usage.) Everytime the server crashes(and boots up again) it won't flush all of the memory, just around 10 MB. So everytime it crashes, it will allocate more it flushed previous. Infinite loop => out of memory.

The reason why you don't see this in the logs is also simply explained: Code will only buffer the last start and won't buffer the rest. So the output I added was just from the last start.

[hazzlewis]

Mine was occurring yesterday on a small project, although with one fairly large file (about 4000 lines of code) but it was allocating 1.8gb which is far more than I'd expect. Also my dev console did mention a memory leak a long with the errors that followed

[hazzlewis]

Occurred again just now whilst i was working on a file which i'd SCPed into the project directory after already having VSCode open for a while. This time, just a handful of small files in this directory. Do you need any more info for debugging?

[jens1o]

Could we get the file? @hazzlewis

[hazzlewis]

If you think it would be helpful, sure. But I've made changes and restarted vscode since the extension host stopped. Kind Regards Harry Lewis

…

-------- Original message -------- From: Jens Hausdorf <notifications@github.com> Date: 19/04/2017 13:58 (GMT+00:00) To: felixfbecker/php-language-server <php-language-server@noreply.github.com> Cc: Harry Lewis <Harry.Lewis@paragon.net.uk>, Mention <mention@noreply.github.com> Subject: Re: [felixfbecker/php-language-server] memory leak (#344) Could we get the file? @hazzlewis<https://github.com/hazzlewis> - You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#344 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ATSpMUQNREmAl--WLGmUDOoqI-bqMYOgks5rxgUGgaJpZM4M3_Nx>.

[twinklebob]

I'm getting the same issue on Code v1.11.2 on Linux. I'm getting it on my Windows machine too, but don't have access to that at the moment.
It seems to crash the Extension host as soon as I save the file.
Right before the errors in the dev console it seems to be dumping the entire content of the page, not sure if this is related:
{"result":[{"range":{"start":{"line":0,"character":0},"end":{"line":341,"character":2}},"newText":"---Entire page content---"}],"id":54,"jsonrpc":"2.0"}

[twinklebob]

Update, just turned off format on save and the problem has gone. I assume that the php-language-server isn't used for that, so isn't the cause of my problem. I'll just leave format on save off.

[felixfbecker]

@twinklebob That is a super helpful tip! Formatting is delegated to PHP CodeSniffer, so either there's a memory leak in there or we don't dispose correctly somewhere.
I would recommend to not format on save because PHP CodeSniffer doesn't reuse any of our ASTs (thus is slow) and from my own experience not always does the best thing. With #357 we will be able to do a losless formatting from our own ASTs.

[felixfbecker]

@jens1o @hazzlewis is the issue caused by that setting for you as well?

[hazzlewis]

I don’t have formatOnSave enabled, and im 99% sure I haven’t used the format document operation on any occasion when mine has crashed. ☹ From: Felix Becker [mailto:notifications@github.com] Sent: 25 April 2017 11:33 To: felixfbecker/php-language-server <php-language-server@noreply.github.com> Cc: Harry Lewis <Harry.Lewis@paragon.net.uk>; Mention <mention@noreply.github.com> Subject: Re: [felixfbecker/php-language-server] memory leak (#344) @jens1o<https://github.com/jens1o> @hazzlewis<https://github.com/hazzlewis> is the issue caused by that setting for you as well? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#344 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ATSpMZWOEWUuL5cex4RHNhdMoeKVx8Dsks5rzcvNgaJpZM4M3_Nx>.