Avoid instantation of class with type mixed during mapping #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could I also get a tag after the merge please? |
|
Maybe good to know this repo is kind of dead. The sole maintainer doesn’t seem to be active anymore. Also see #59 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some PHP 8+ coding standards require the specification of a typehint in all parameters of all functions, even if it's just a
mixedtypehint.Unfortunately, the library treats
mixedtypehints as a concrete class type, trying to automatically map passed objects.This is undesirable for methods like LSP's executeCommand, which takes an
LSPAny = LSPObject | LSPArray | string | integer | uinteger | decimal | boolean | nullarg, essentially equivalent to amixedtype.This library already supports skipping by not providing a typehint: this PR allow skipping mapping by also providing a
mixedtypehint.